search

apolopena / gitpod-laravel-starter

Configurable LAMP or LEMP stack starter project powered by Laravel and Gitpod. Supports Laravel 6, 7, and 8. Out of the box support for React, Vue, and Bootstrap frontends, with or without built-in auth .
https://github.com/apolopena/gitpod-laravel-starter/wiki
MIT License
40 stars 44 forks source link

Make react example presets use their own package.json #185

Closed apolopena closed 2 years ago

apolopena commented 2 years ago

Describe the bug

The react preset example repositories do not use their own package.json and since gls (gitpod-laravel-starter) uses 8.* this means that any of the dev dependencies for the project can be bumped up at any time. This can break all kinds of things. A perfect example of this being a problem is https://github.com/apolopena/gitpod-laravel-starter/issues/184

Screenshots

Steps to reproduce

See https://github.com/apolopena/gitpod-laravel-starter/issues/184

Expected behavior

See https://github.com/apolopena/gitpod-laravel-starter/issues/184

Additional information

Including a package.json in the react preset example will pin down major versions of the packages. This should fix the issue

apolopena commented 2 years ago

Fixed, vue example works (outside of an iframe only) as well. image