search

apolopena / gitpod-laravel-starter

Configurable LAMP or LEMP stack starter project powered by Laravel and Gitpod. Supports Laravel 6, 7, and 8. Out of the box support for React, Vue, and Bootstrap frontends, with or without built-in auth .
https://github.com/apolopena/gitpod-laravel-starter/wiki
MIT License
40 stars 44 forks source link

Support PHP 8.0 explicity in starter.ini #204

Open apolopena opened 2 years ago

apolopena commented 2 years ago

Problem this feature will solve

A user should be able to specify PHP 8.0 explicitly in starter.ini rather than relying on the value gitpodlatest to do the job. Also once Gitpod bumps their PHP version up past 8.0. Users will need to be able to explicitly set PHP 8.0 in starter.ini

Background

Proposed Solution

Support 8.0 as a value for version in [PHP] in starter.ini

Constraints and Assumptions

Alternatives or Workarounds

Additional context

Add any other context or screenshots about the feature request here.

strausmann commented 2 years ago

Shouldn't the whole thing just be kept dynamic so that you could also install PHP 8.1, for example? It is clear to me that PHP 8.0 and 8.1 are very rarely used.

apolopena commented 2 years ago

Since there is a potential purge of the existing (gitpod) PHP before the install It is like half dynamic ATM. Only versions 'supported' in starter.ini can be used because the PPA's and packages that get installed are different per PHP version so those need to be hardcoded in .gp/bash/php.sh also apache might need different treatment in an upcoming PHP release. We would still need to error handle invalid PHP versions such as 22.4 etc....

So this is why I have half the system hardcoded. Perhaps we can think of a better way...