search

aporat / store-receipt-validator

PHP receipt validator for Apple iTunes, Google Play and Amazon App Store
Apache License 2.0
633 stars 153 forks source link

Following semver and codestyle #86

Closed Stafox closed 5 years ago

Stafox commented 5 years ago

What about if we strongly will follow semver (https://semver.org/) and PSR-2 codestyle (https://www.php-fig.org/psr/psr-2/)?

At least let's start to use variables and properties in camelCase and increasing major version if backward compatibility was breaked.

@aporat I'm ok if you will mention me when merge is needed to check possible BC violations.

soren121 commented 5 years ago

Yes, please follow semver. The upgrade from 2.1.0 to 2.2.0 broke my application, which shouldn't ever happen on a minor version upgrade.

aporat commented 5 years ago

thanks, @Stafox you're right. I'll tag a new major release when there are breaking changes in the api from now on