aporeto-inc / trireme-lib

Simple, scalable and secure application segmentation
https://trireme.io
Apache License 2.0
299 stars 51 forks source link

fix: 3.14 #1015

Closed sibicramesh closed 4 years ago

sibicramesh commented 4 years ago

--> Fixed missing code from Mehuls fix for dup ack. --> Merged counters fix. --> Merged timestamp on counterreport.

codecov[bot] commented 4 years ago

Codecov Report

Merging #1015 into release-3.14.0 will decrease coverage by 0.64%. The diff coverage is 26.66%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-3.14.0    #1015      +/-   ##
==================================================
- Coverage           55.44%   54.80%   -0.65%     
==================================================
  Files                 124      126       +2     
  Lines               12062    12275     +213     
==================================================
+ Hits                 6688     6727      +39     
- Misses               4742     4921     +179     
+ Partials              632      627       -5     
Impacted Files Coverage Δ
...ller/internal/enforcer/nfqdatapath/datapath_udp.go 0.00% <0.00%> (ø)
...internal/enforcer/nfqdatapath/nflog/nflog_linux.go 20.00% <ø> (-3.81%) :arrow_down:
controller/pkg/connection/connection.go 13.95% <0.00%> (+0.31%) :arrow_up:
controller/pkg/tokens/errors.go 0.00% <0.00%> (ø)
controller/pkg/tokens/jwt.go 86.48% <0.00%> (ø)
...ler/internal/enforcer/nfqdatapath/countererrors.go 1.88% <1.88%> (ø)
controller/pkg/tokens/binaryjwt.go 62.83% <14.70%> (-0.40%) :arrow_down:
...ller/internal/enforcer/nfqdatapath/datapath_tcp.go 53.86% <49.15%> (+0.70%) :arrow_up:
...oller/internal/supervisor/iptablesctrl/iptables.go 55.24% <50.00%> (+0.18%) :arrow_up:
...ntroller/internal/enforcer/nfqdatapath/datapath.go 57.76% <61.90%> (+0.08%) :arrow_up:
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update adc08a6...7d32fff. Read the comment docs.

sibicramesh commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "tar",
    "component": "enforcerd",
    "pr-id": "1637",
    "commit-sha": "0e36a4b2fafb08a6d516986f2250a14d9710a6f4",
    "pipeline": "master"
  },
  {
    "project": "tar",
    "component": "trireme-lib",
    "pr-id": "1015",
    "commit-sha": "7d32fff9734a53d9a3f2556dea4b42ce2a0c3f75",
    "pipeline": "master"
  }
]
sibicramesh commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "tar",
    "component": "trireme-lib",
    "pr-id": "1015",
    "commit-sha": "7d32fff9734a53d9a3f2556dea4b42ce2a0c3f75",
    "pipeline": "release-3.14.0"
  },
  {
    "project": "tar",
    "component": "enforcerd",
    "pr-id": "1637",
    "commit-sha": "0e36a4b2fafb08a6d516986f2250a14d9710a6f4",
    "pipeline": "release-3.14.0"
  }
]