search

aporeto-inc / trireme-lib

Simple, scalable and secure application segmentation
https://trireme.io
Apache License 2.0
299 stars 51 forks source link

Dont use hmark for legacy acls (#1016) #1018

Closed amitlimaye closed 4 years ago

amitlimaye commented 4 years ago

Co-authored-by: Amit Limaye alimaye@paloaltonetworks.com

Description

Changes proposed in this pull request.

Test plan

Outline the test plan used to test this change before merging it.

Fixes #.

codecov[bot] commented 4 years ago

Codecov Report

Merging #1018 into release-3.14.0 will increase coverage by 0.00%. The diff coverage is 83.33%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.14.0    #1018   +/-   ##
===============================================
  Coverage           54.80%   54.80%           
===============================================
  Files                 126      126           
  Lines               12275    12276    +1     
===============================================
+ Hits                 6727     6728    +1     
  Misses               4921     4921           
  Partials              627      627
Impacted Files Coverage Δ
...ontroller/internal/supervisor/iptablesctrl/acls.go 68.91% <0.00%> (ø)
...ller/internal/supervisor/iptablesctrl/templates.go 87.24% <100.00%> (+0.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2d7fbf9...77c3d87. Read the comment docs.