search

aporeto-inc / trireme-lib

Simple, scalable and secure application segmentation
https://trireme.io
Apache License 2.0
299 stars 51 forks source link

Dont user hmark for legacy acls #1019

Open amitlimaye opened 4 years ago

amitlimaye commented 4 years ago

Description

Changes proposed in this pull request.

Test plan

Outline the test plan used to test this change before merging it.

Fixes #.

aporeto-bot commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1634",
    "commit-sha": "3e01b1cd9704df5f62b58ffdaea1aad194d55c1b",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "1019",
    "commit-sha": "f6b4263850a4b41008b7daab00ec1cf269b8057a",
    "pipeline": "master"
  }
]
codecov[bot] commented 4 years ago

Codecov Report

Merging #1019 into release-3.13.0 will increase coverage by <.01%. The diff coverage is 83.33%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-3.13.0    #1019      +/-   ##
==================================================
+ Coverage           57.96%   57.97%   +<.01%     
==================================================
  Files                 112      112              
  Lines               11453    11454       +1     
==================================================
+ Hits                 6639     6640       +1     
  Misses               4194     4194              
  Partials              620      620
Impacted Files Coverage Δ
...ontroller/internal/supervisor/iptablesctrl/acls.go 65.18% <0%> (ø) :arrow_up:
...ller/internal/supervisor/iptablesctrl/templates.go 88.43% <100%> (+0.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8aa5b86...f6b4263. Read the comment docs.

aporeto-bot commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1634",
    "commit-sha": "3e01b1cd9704df5f62b58ffdaea1aad194d55c1b",
    "pipeline": "release-3.13."
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "1019",
    "commit-sha": "f6b4263850a4b41008b7daab00ec1cf269b8057a",
    "pipeline": "release-3.13."
  }
]
aporeto-bot commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1634",
    "commit-sha": "3e01b1cd9704df5f62b58ffdaea1aad194d55c1b",
    "pipeline": "release-3.13.0"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "1019",
    "commit-sha": "f6b4263850a4b41008b7daab00ec1cf269b8057a",
    "pipeline": "release-3.13.0"
  }
]
aporeto-bot commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1634",
    "commit-sha": "3e01b1cd9704df5f62b58ffdaea1aad194d55c1b",
    "pipeline": "release-3.13.0"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "1019",
    "commit-sha": "f6b4263850a4b41008b7daab00ec1cf269b8057a",
    "pipeline": "release-3.13.0"
  }
]