search

aporeto-inc / trireme-lib

Simple, scalable and secure application segmentation
https://trireme.io
Apache License 2.0
300 stars 51 forks source link

fixing rpc server for dns reports. #874

Closed 0xmchadha closed 5 years ago

0xmchadha commented 5 years ago

Description

Changes proposed in this pull request.

Test plan

Outline the test plan used to test this change before merging it.

Fixes #.

codecov[bot] commented 5 years ago

Codecov Report

Merging #874 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #874      +/-   ##
==========================================
+ Coverage   56.03%   56.03%   +<.01%     
==========================================
  Files         110      110              
  Lines       11053    11050       -3     
==========================================
- Hits         6193     6192       -1     
+ Misses       4255     4254       -1     
+ Partials      605      604       -1
Impacted Files Coverage Δ
...ontroller/internal/enforcer/dnsproxy/dns_report.go 95.65% <ø> (ø) :arrow_up:
controller/internal/enforcer/dnsproxy/dns.go 67.41% <100%> (+1.11%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 47b3913...5d41847. Read the comment docs.

0xmchadha commented 5 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "fix-rpc-server",
    "component": "enforcerd",
    "pr-id": "1376",
    "commit-sha": "9babecc473751feb133a5f4f7078f64e41d790ac"
  },
  {
    "project": "fix-rpc-server",
    "component": "trireme-lib",
    "pr-id": "874",
    "commit-sha": "5d418473ad8bbcfe726eb7e1fdf7753a71a28573"
  }
]
mheese commented 5 years ago

all the FTs that are failing are irrelevant ... going to merge this now