search

aporeto-inc / trireme-lib

Simple, scalable and secure application segmentation
https://trireme.io
Apache License 2.0
300 stars 51 forks source link

Fix iptables update #875

Closed 0xmchadha closed 5 years ago

0xmchadha commented 5 years ago

If updates fail, the version should not be updated. This PR fixes that.

sibicramesh commented 5 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1376",
    "commit-sha": "ffa602cd65ff12f1976ece68bd349f3678f537d4"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "875",
    "commit-sha": "fa7f9a7a8067179d7a2b2a34a73f1702d366a209"
  }
]
sibicramesh commented 5 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1376",
    "commit-sha": "ffa602cd65ff12f1976ece68bd349f3678f537d4"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "875",
    "commit-sha": "370ea0576d4be9fa09455c1b90e9cf969d34bfd6"
  }
]
0xmchadha commented 5 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1376",
    "commit-sha": "ffa602cd65ff12f1976ece68bd349f3678f537d4"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "875",
    "commit-sha": "1134638eba2e19502eef88fb7584ef293107be02"
  }
]
0xmchadha commented 5 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1376",
    "commit-sha": "ffa602cd65ff12f1976ece68bd349f3678f537d4"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "875",
    "commit-sha": "32665f630996d59bc0671f59af6fa147d3fe1f77"
  }
]
0xmchadha commented 5 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1376",
    "commit-sha": "ffa602cd65ff12f1976ece68bd349f3678f537d4"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "875",
    "commit-sha": "ce4424cd92df8fc225c035672d8d5694950feda8"
  }
]
codecov[bot] commented 5 years ago

Codecov Report

Merging #875 into master will decrease coverage by 0.01%. The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #875      +/-   ##
==========================================
- Coverage   56.03%   56.01%   -0.02%     
==========================================
  Files         110      110              
  Lines       11050    11050              
==========================================
- Hits         6192     6190       -2     
- Misses       4254     4256       +2     
  Partials      604      604
Impacted Files Coverage Δ
...oller/internal/supervisor/iptablesctrl/iptables.go 61.22% <0%> (-0.18%) :arrow_down:
controller/internal/supervisor/supervisor.go 68.39% <80%> (-0.68%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b91c12d...ce4424c. Read the comment docs.

0xmchadha commented 5 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1376",
    "commit-sha": "ffa602cd65ff12f1976ece68bd349f3678f537d4"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "875",
    "commit-sha": "ce4424cd92df8fc225c035672d8d5694950feda8"
  }
]
0xmchadha commented 5 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1376",
    "commit-sha": "9a1ba5c9828ee2fecd2c69516542684b2d8111bf"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "875",
    "commit-sha": "ce4424cd92df8fc225c035672d8d5694950feda8"
  }
]
0xmchadha commented 5 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1376",
    "commit-sha": "9a1ba5c9828ee2fecd2c69516542684b2d8111bf"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "875",
    "commit-sha": "ce4424cd92df8fc225c035672d8d5694950feda8"
  }
]
0xmchadha commented 5 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1376",
    "commit-sha": "9a1ba5c9828ee2fecd2c69516542684b2d8111bf"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "875",
    "commit-sha": "ce4424cd92df8fc225c035672d8d5694950feda8"
  }
]
0xmchadha commented 5 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1376",
    "commit-sha": "9a1ba5c9828ee2fecd2c69516542684b2d8111bf"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "875",
    "commit-sha": "ce4424cd92df8fc225c035672d8d5694950feda8"
  }
]
0xmchadha commented 5 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1376",
    "commit-sha": "522f96d5c6b724e595477e9aaf7dda14870c9c8d"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "875",
    "commit-sha": "ce4424cd92df8fc225c035672d8d5694950feda8"
  }
]