aporeto-inc / trireme-lib

Simple, scalable and secure application segmentation
https://trireme.io
Apache License 2.0
300 stars 51 forks source link

Fixes the iptables-restore cleanups #904

Closed dstiliadis closed 4 years ago

dstiliadis commented 4 years ago

Fix the iptalbles-restore cleanups for Linux services. It essentially removes the spurious errors. The problem is that with Linux services we do not want to commit anything to iptables until there is a real service involved. This is handled correctly by making the list commands merge the current state of iptables with the buffer that is maintained in the system.,

dstiliadis commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1457",
    "commit-sha": "2436847fb590f6b8d87fdc1f28168d2813663e20"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "904",
    "commit-sha": "a41597edfde63fc757394ac006e8e541e4d1f5f2"
  }
]
codecov[bot] commented 4 years ago

Codecov Report

Merging #904 into master will decrease coverage by 0.02%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #904      +/-   ##
==========================================
- Coverage   55.85%   55.82%   -0.03%     
==========================================
  Files         110      110              
  Lines       11059    11072      +13     
==========================================
+ Hits         6177     6181       +4     
- Misses       4284     4293       +9     
  Partials      598      598
Impacted Files Coverage Δ
controller/pkg/aclprovider/iptablesprovider.go 34.78% <0%> (-2.34%) :arrow_down:
...ontroller/internal/supervisor/iptablesctrl/acls.go 65.66% <0%> (+1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 73e249e...a41597e. Read the comment docs.

dstiliadis commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1457",
    "commit-sha": "30911336022b60b5d390eb4f4523aee4d04d23d4"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "904",
    "commit-sha": "a41597edfde63fc757394ac006e8e541e4d1f5f2"
  }
]