aporeto-inc / trireme-lib

Simple, scalable and secure application segmentation
https://trireme.io
Apache License 2.0
300 stars 51 forks source link

clear ipset destroy list after all the unused ipsets have been destroyed #922

Closed 0xmchadha closed 4 years ago

0xmchadha commented 4 years ago

There is a list we maintain that is used to destroy ipsets when it is safe to destroy them. There was a bug where this list wasnt being cleared. Although it wasnt affecting any communication because ipsets themselves have reference in the iptables. This PR fixes that bug.

0xmchadha commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1514",
    "commit-sha": "d3cc39a165c2bfc011100883f14e9b7e7a0e4223"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "922",
    "commit-sha": "bd3995c66741ee20e3bc4f33182674f71492dcfc"
  }
]
0xmchadha commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1514",
    "commit-sha": "d3cc39a165c2bfc011100883f14e9b7e7a0e4223"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "922",
    "commit-sha": "bd3995c66741ee20e3bc4f33182674f71492dcfc"
  }
]
0xmchadha commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1514",
    "commit-sha": "d3cc39a165c2bfc011100883f14e9b7e7a0e4223"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "922",
    "commit-sha": "bd3995c66741ee20e3bc4f33182674f71492dcfc"
  }
]