aporeto-inc / trireme-lib

Simple, scalable and secure application segmentation
https://trireme.io
Apache License 2.0
300 stars 51 forks source link

fix tcp option parsing #927

Closed amitlimaye closed 4 years ago

amitlimaye commented 4 years ago

Description

Changes proposed in this pull request.

Test plan

Outline the test plan used to test this change before merging it.

Fixes #.

codecov[bot] commented 4 years ago

Codecov Report

Merging #927 into master will decrease coverage by 0.32%. The diff coverage is 62.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #927      +/-   ##
==========================================
- Coverage   55.79%   55.46%   -0.33%     
==========================================
  Files         110      110              
  Lines       11114    11125      +11     
==========================================
- Hits         6201     6171      -30     
- Misses       4314     4356      +42     
+ Partials      599      598       -1
Impacted Files Coverage Δ
controller/pkg/packet/packet.go 51.94% <62.5%> (-13.14%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1283ca8...e85ef6b. Read the comment docs.

amitlimaye commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1520",
    "commit-sha": "c4b57050ea3db8e79287c9b93a582c77c9ebbc6a"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "927",
    "commit-sha": "fa6ec5d65a1507b2374fb4252dbaa9cee035b3c8"
  }
]
amitlimaye commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1520",
    "commit-sha": "c4b57050ea3db8e79287c9b93a582c77c9ebbc6a"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "927",
    "commit-sha": "a39dfcb7fdeb65106463b2a66e4cac530b252cf7"
  }
]
amitlimaye commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1520",
    "commit-sha": "396e2dabedaf136e829e7159feed0976f7de3358"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "927",
    "commit-sha": "e85ef6b6e103820b15db65d3108e2cf329278cb3"
  }
]