search

aporeto-inc / trireme-lib

Simple, scalable and secure application segmentation
https://trireme.io
Apache License 2.0
300 stars 51 forks source link

fix tcp option parsing #928

Closed amitlimaye closed 4 years ago

amitlimaye commented 4 years ago

Description

Changes proposed in this pull request.

Test plan

Outline the test plan used to test this change before merging it.

Fixes #.

codecov[bot] commented 4 years ago

Codecov Report

Merging #928 into release-3.12.0 will decrease coverage by 0.32%. The diff coverage is 62.5%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-3.12.0    #928      +/-   ##
=================================================
- Coverage           55.53%   55.2%   -0.33%     
=================================================
  Files                 105     105              
  Lines               10678   10658      -20     
=================================================
- Hits                 5930    5884      -46     
- Misses               4167    4195      +28     
+ Partials              581     579       -2
Impacted Files Coverage Δ
controller/pkg/packet/packet.go 51.94% <62.5%> (-13.14%) :arrow_down:
...ller/internal/supervisor/iptablesctrl/templates.go 89.56% <0%> (-0.09%) :arrow_down:
...ontroller/internal/supervisor/iptablesctrl/ipv6.go 61.81% <0%> (ø) :arrow_up:
monitor/internal/pod/monitor.go 0% <0%> (ø) :arrow_up:
monitor/internal/pod/config.go 100% <0%> (ø) :arrow_up:
...troller/internal/enforcer/nfqdatapath/nfq_linux.go 11.02% <0%> (ø) :arrow_up:
...ller/internal/enforcer/nfqdatapath/datapath_tcp.go 58.69% <0%> (+0.37%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 48e15a5...20680aa. Read the comment docs.