search

aporeto-inc / trireme-lib

Simple, scalable and secure application segmentation
https://trireme.io
Apache License 2.0
300 stars 51 forks source link

Fixing Kubernetes monitor delete controller: adding node name check #941

Closed mheese closed 4 years ago

mheese commented 4 years ago

Fixes https://github.com/aporeto-inc/aporeto/issues/2460

aporeto-bot commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "fix-k8s-delete-controller",
    "component": "enforcerd",
    "pr-id": "1534",
    "commit-sha": "1cb444375e4060eed572038b21b890076727ba70"
  },
  {
    "project": "fix-k8s-delete-controller",
    "component": "trireme-lib",
    "pr-id": "941",
    "commit-sha": "0f092cbc5073ed129a1af32788dbe97a1c9b272b"
  }
]
codecov[bot] commented 4 years ago

Codecov Report

Merging #941 into master will increase coverage by 0.17%. The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #941      +/-   ##
==========================================
+ Coverage   56.28%   56.45%   +0.17%     
==========================================
  Files         111      111              
  Lines       11167    11179      +12     
==========================================
+ Hits         6285     6311      +26     
+ Misses       4283     4265      -18     
- Partials      599      603       +4
Impacted Files Coverage Δ
monitor/internal/pod/monitor.go 0% <0%> (ø) :arrow_up:
monitor/internal/pod/delete_controller.go 86.11% <88.88%> (+16.31%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4d4f3b8...0f092cb. Read the comment docs.