Follow-up from #943 . Adding better logging for http client certs and adding stops in envoy.
There could be a lot more done in both packages that are touched here. However, especially the http package stands out: logging is not very clear, UT missing (in the works though for envoy by Abhi), a lot of variable/pointer checks missing, unclear return values and missing errors - should at least have a comment if they are intended, ignoring golang best practices and not very elegant code. One can see that this was written down in a hurry, and fixed in a hurry by us recently as well :) This package deserves some love.
Anyway, I leave it up to @brianonn and @abhijitherekar to add more to this PR if you think that is necessary.
@brianonn I ignored the Gopkg.toml comment from #943 as I don't think we need to change anything. Please comment here if you think otherwise.
Follow-up from #943 . Adding better logging for http client certs and adding stops in envoy.
There could be a lot more done in both packages that are touched here. However, especially the http package stands out: logging is not very clear, UT missing (in the works though for envoy by Abhi), a lot of variable/pointer checks missing, unclear return values and missing errors - should at least have a comment if they are intended, ignoring golang best practices and not very elegant code. One can see that this was written down in a hurry, and fixed in a hurry by us recently as well :) This package deserves some love.
Anyway, I leave it up to @brianonn and @abhijitherekar to add more to this PR if you think that is necessary.
@brianonn I ignored the
Gopkg.tomlcomment from #943 as I don't think we need to change anything. Please comment here if you think otherwise.