search

aporeto-inc / trireme-lib

Simple, scalable and secure application segmentation
https://trireme.io
Apache License 2.0
300 stars 51 forks source link

fix: pu name being reveresed when claims are bad #958

Closed sibicramesh closed 4 years ago

sibicramesh commented 4 years ago

--> When the token is missing or invalid, we mistakenly reverse the pu name and report it.

sibicramesh commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1559",
    "commit-sha": "be66ef983d16066066a6c086c8350ab2b3978a41",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "958",
    "commit-sha": "f6499faa94a16f134c7de907e1dcf0f850db2aaa",
    "pipeline": "master"
  }
]
sibicramesh commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1567",
    "commit-sha": "0e0f4cfd3c49c71152da486af872071aa789bff7",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "958",
    "commit-sha": "f6499faa94a16f134c7de907e1dcf0f850db2aaa",
    "pipeline": "master"
  }
]
codecov[bot] commented 4 years ago

Codecov Report

Merging #958 into master will decrease coverage by 0.08%. The diff coverage is 74.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #958      +/-   ##
==========================================
- Coverage   54.36%   54.27%   -0.09%     
==========================================
  Files         123      124       +1     
  Lines       11815    11965     +150     
==========================================
+ Hits         6423     6494      +71     
- Misses       4764     4850      +86     
+ Partials      628      621       -7
Impacted Files Coverage Δ
...ller/internal/enforcer/nfqdatapath/datapath_udp.go 0% <0%> (ø) :arrow_up:
...r/internal/enforcer/nfqdatapath/diagnostics_tcp.go 0% <0%> (ø) :arrow_up:
controller/pkg/tokens/jwt.go 86.48% <100%> (-0.13%) :arrow_down:
...forcer/internal/statscollector/collector_reader.go 32.14% <100%> (-10.36%) :arrow_down:
...nforcer/nfqdatapath/tokenaccessor/tokenaccessor.go 92.94% <100%> (ø)
...ntroller/internal/enforcer/nfqdatapath/datapath.go 57.14% <100%> (+1.18%) :arrow_up:
controller/pkg/connection/connection.go 13.63% <100%> (ø)
...emoteenforcer/internal/statscollector/collector.go 100% <100%> (ø) :arrow_up:
...ontroller/internal/enforcer/proxy/enforcerproxy.go 78.77% <33.33%> (+0.55%) :arrow_up:
controller/internal/enforcer/proxy/rpcserver.go 19.14% <45%> (-8.93%) :arrow_down:
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f6499fa...ffadee9. Read the comment docs.

sibicramesh commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1582",
    "commit-sha": "523ed33fd6f27d7ceb602edd200900645bf32ddf",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "958",
    "commit-sha": "ffadee9b09c2719d374e2c14eb5a23eb2590ef4d",
    "pipeline": "master"
  }
]
sibicramesh commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1582",
    "commit-sha": "523ed33fd6f27d7ceb602edd200900645bf32ddf",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "958",
    "commit-sha": "ffadee9b09c2719d374e2c14eb5a23eb2590ef4d",
    "pipeline": "master"
  }
]
sibicramesh commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1582",
    "commit-sha": "523ed33fd6f27d7ceb602edd200900645bf32ddf",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "958",
    "commit-sha": "ffadee9b09c2719d374e2c14eb5a23eb2590ef4d",
    "pipeline": "master"
  }
]
sibicramesh commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1586",
    "commit-sha": "74fdae0273e9e9cf26b86c990f53aa90f6f3dc34",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "958",
    "commit-sha": "ffadee9b09c2719d374e2c14eb5a23eb2590ef4d",
    "pipeline": "master"
  }
]