search

aporeto-inc / trireme-lib

Simple, scalable and secure application segmentation
https://trireme.io
Apache License 2.0
300 stars 51 forks source link

with aporeto iptables we do not need to check for ip6tables #960

Open 0xmchadha opened 4 years ago

0xmchadha commented 4 years ago

Description

Changes proposed in this pull request.

Test plan

Outline the test plan used to test this change before merging it.

Fixes #.

0xmchadha commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1569",
    "commit-sha": "dbfcccd23c2b3b48c7369f18298f9c832e0cd91e",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "960",
    "commit-sha": "26f53935ea7630a37871ffabecbaab7d227a5ba1",
    "pipeline": "master"
  }
]
0xmchadha commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1569",
    "commit-sha": "dbfcccd23c2b3b48c7369f18298f9c832e0cd91e",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "960",
    "commit-sha": "472f8732d41ca2526a660ff8dc0012713f33f3fb",
    "pipeline": "master"
  }
]
codecov[bot] commented 4 years ago

Codecov Report

Merging #960 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #960      +/-   ##
==========================================
+ Coverage   54.36%   54.37%   +<.01%     
==========================================
  Files         123      123              
  Lines       11814    11816       +2     
==========================================
+ Hits         6423     6425       +2     
  Misses       4764     4764              
  Partials      627      627
Impacted Files Coverage Δ
utils/crypto/crypto.go 78.37% <100%> (ø) :arrow_up:
...ontroller/internal/supervisor/iptablesctrl/ipv6.go 96.29% <100%> (+0.14%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 26f5393...f8de4e5. Read the comment docs.

0xmchadha commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1569",
    "commit-sha": "dbfcccd23c2b3b48c7369f18298f9c832e0cd91e",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "960",
    "commit-sha": "f8de4e5d3f75cf0d842483d97cbec60496d673aa",
    "pipeline": "master"
  }
]