search

aporeto-inc / trireme-lib

Simple, scalable and secure application segmentation
https://trireme.io
Apache License 2.0
300 stars 51 forks source link

Return early if options are bad #962

Closed amitlimaye closed 4 years ago

amitlimaye commented 4 years ago

Description

Changes proposed in this pull request.

Test plan

Outline the test plan used to test this change before merging it.

Fixes #.

amitlimaye commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "962",
    "commit-sha": "fe3f0fbce4cb47e714c9db46cd1d7afe118670ba",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1574",
    "commit-sha": "d2855202f3985a58577ca270e0ae7a0c209b569a",
    "pipeline": "master"
  }
]
codecov[bot] commented 4 years ago

Codecov Report

Merging #962 into master will decrease coverage by 0.14%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #962      +/-   ##
==========================================
- Coverage   54.46%   54.32%   -0.15%     
==========================================
  Files         122      122              
  Lines       11724    11727       +3     
==========================================
- Hits         6386     6371      -15     
- Misses       4710     4733      +23     
+ Partials      628      623       -5
Impacted Files Coverage Δ
controller/pkg/packet/packet.go 52.44% <100%> (+0.5%) :arrow_up:
monitor/extractors/linux.go 48.78% <0%> (-21.96%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d5f31a9...8669713. Read the comment docs.

amitlimaye commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "962",
    "commit-sha": "bb09607e4bb6ad8943aa06c741d0c19eb5c1ae87",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1574",
    "commit-sha": "d2855202f3985a58577ca270e0ae7a0c209b569a",
    "pipeline": "master"
  }
]
amitlimaye commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "962",
    "commit-sha": "bb09607e4bb6ad8943aa06c741d0c19eb5c1ae87",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1574",
    "commit-sha": "ad7bc4f141ca6d5d2bc30ca056e2dee41f50a9ef",
    "pipeline": "master"
  }
]
amitlimaye commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1574",
    "commit-sha": "85189b672150886f8ac12933689b3ba2798bfd15",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "962",
    "commit-sha": "bb09607e4bb6ad8943aa06c741d0c19eb5c1ae87",
    "pipeline": "master"
  }
]
amitlimaye commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1574",
    "commit-sha": "7b33a264b0f84de6e455b490b36b34f056b60434",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "962",
    "commit-sha": "bb09607e4bb6ad8943aa06c741d0c19eb5c1ae87",
    "pipeline": "master"
  }
]
amitlimaye commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "962",
    "commit-sha": "44345a69112c3efd5ac26b39bb02e26cc04cc12f",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1574",
    "commit-sha": "7b33a264b0f84de6e455b490b36b34f056b60434",
    "pipeline": "master"
  }
]
amitlimaye commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1578",
    "commit-sha": "eeafa00a136851bd20b42909ccf53d26e943d10e",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "962",
    "commit-sha": "44345a69112c3efd5ac26b39bb02e26cc04cc12f",
    "pipeline": "master"
  }
]
amitlimaye commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1578",
    "commit-sha": "eeafa00a136851bd20b42909ccf53d26e943d10e",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "962",
    "commit-sha": "8669713e93164052f766172a07ae453a5c958cdf",
    "pipeline": "master"
  }
]
aporeto-bot commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1574",
    "commit-sha": "7b33a264b0f84de6e455b490b36b34f056b60434",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "962",
    "commit-sha": "8669713e93164052f766172a07ae453a5c958cdf",
    "pipeline": "master"
  }
]