aporeto-inc / trireme-lib

Simple, scalable and secure application segmentation
https://trireme.io
Apache License 2.0
300 stars 51 forks source link

Brianonn pr968 nodebug nobypass #969

Open brianonn opened 4 years ago

brianonn commented 4 years ago

removed debug statements from PR 968

codecov[bot] commented 4 years ago

Codecov Report

Merging #969 into release-3.13.0 will increase coverage by 0.48%. The diff coverage is 14.28%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-3.13.0     #969      +/-   ##
==================================================
+ Coverage           56.51%   56.99%   +0.48%     
==================================================
  Files                 111      111              
  Lines               11250    11951     +701     
==================================================
+ Hits                 6358     6812     +454     
- Misses               4284     4482     +198     
- Partials              608      657      +49
Impacted Files Coverage Δ
...oller/internal/supervisor/iptablesctrl/iptables.go 56.11% <0%> (-0.48%) :arrow_down:
controller/pkg/aclprovider/iptablesprovider.go 48.35% <20%> (-0.22%) :arrow_down:
controller/pkg/packet/packet.go 49.7% <0%> (-2.24%) :arrow_down:
...ller/internal/enforcer/nfqdatapath/datapath_udp.go 0% <0%> (ø) :arrow_up:
...roller/internal/enforcer/nfqdatapath/test_utils.go 75% <0%> (ø) :arrow_up:
controller/pkg/tokens/jwt.go 85.62% <0%> (+2.9%) :arrow_up:
controller/pkg/tokens/binaryjwt.go 63.73% <0%> (+3.02%) :arrow_up:
...ller/internal/enforcer/nfqdatapath/datapath_tcp.go 62.6% <0%> (+3.05%) :arrow_up:
...ntroller/internal/enforcer/nfqdatapath/datapath.go 69.13% <0%> (+5.67%) :arrow_up:
controller/internal/enforcer/nfqdatapath/utils.go 85.41% <0%> (+6.25%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 084ff24...83aeb5c. Read the comment docs.

brianonn commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1573",
    "commit-sha": "dacb828bec8ce40e41f6293b27376d0d5f811291",
    "pipeline": "release-3.13.0"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "969",
    "commit-sha": "83aeb5c71593d9b35e5067e59e745c756a6a597e",
    "pipeline": "release-3.13.0"
  }
]