aporeto-inc / trireme-lib

Simple, scalable and secure application segmentation
https://trireme.io
Apache License 2.0
299 stars 51 forks source link

add go1.14 and master to the build matrix #980

Closed brianonn closed 4 years ago

brianonn commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "980",
    "commit-sha": "eeaf15abc0d4af002c6b80d44f3fbe954adfc43f",
    "pipeline": "master"
  }
]
brianonn commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "980",
    "commit-sha": "9543105ca629f4a9105809621ee3246522fdfb4d",
    "pipeline": "master"
  }
]
brianonn commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "980",
    "commit-sha": "5f8e971f2030541259f2faf25644d3ee3d073dbb",
    "pipeline": "master"
  }
]
brianonn commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "980",
    "commit-sha": "235d2f7168928a53b458a05e8db1a7605fb718a2",
    "pipeline": "master"
  }
]
brianonn commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1602",
    "commit-sha": "6353a9d20d0734fa75d8141de6b3813de96dea8d",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "980",
    "commit-sha": "235d2f7168928a53b458a05e8db1a7605fb718a2",
    "pipeline": "master"
  }
]
brianonn commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1602",
    "commit-sha": "6353a9d20d0734fa75d8141de6b3813de96dea8d",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "980",
    "commit-sha": "235d2f7168928a53b458a05e8db1a7605fb718a2",
    "pipeline": "master"
  }
]
codecov[bot] commented 4 years ago

Codecov Report

Merging #980 into master will increase coverage by 0.48%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #980      +/-   ##
==========================================
+ Coverage   54.28%   54.76%   +0.48%     
==========================================
  Files         124      124              
  Lines       11971    12026      +55     
==========================================
+ Hits         6498     6586      +88     
+ Misses       4852     4807      -45     
- Partials      621      633      +12
Impacted Files Coverage Δ
controller/internal/processmon/processmon.go 80.19% <0%> (+2.47%) :arrow_up:
monitor/internal/pod/resync.go 77.02% <0%> (+2.7%) :arrow_up:
monitor/extractors/linux.go 70.73% <0%> (+21.95%) :arrow_up:
monitor/internal/pod/monitor.go 40.38% <0%> (+40.38%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 197e1e3...879189b. Read the comment docs.

brianonn commented 4 years ago

looks good ... this has passed FT before with the exception of the currently failing tests that Sibi and Pritesh are working on, right? If yes, I will merge this.

Yes, this passed FT before and only needs these changes to pass unit tests on go1.14