search

aporeto-inc / trireme-lib

Simple, scalable and secure application segmentation
https://trireme.io
Apache License 2.0
299 stars 51 forks source link

drop duplicate ack packets with fast open #983

Closed 0xmchadha closed 4 years ago

0xmchadha commented 4 years ago

Description

Changes proposed in this pull request.

Test plan

Outline the test plan used to test this change before merging it.

Fixes #.

sibicramesh commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1604",
    "commit-sha": "a5e69aa277e3c8e79d3bccad71488ee2b31d98a7",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "983",
    "commit-sha": "f4fd639a963426e4155364bd35b346ed1466f0e9",
    "pipeline": "master"
  }
]
0xmchadha commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1604",
    "commit-sha": "a5e69aa277e3c8e79d3bccad71488ee2b31d98a7",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "983",
    "commit-sha": "1cbb70ea6502b157ee0de91b28fe14c9ced9c002",
    "pipeline": "master"
  }
]
0xmchadha commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1604",
    "commit-sha": "a5e69aa277e3c8e79d3bccad71488ee2b31d98a7",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "983",
    "commit-sha": "31d916b4b11914a4236643a963ed5e143c7aa66a",
    "pipeline": "master"
  }
]
0xmchadha commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1604",
    "commit-sha": "a5e69aa277e3c8e79d3bccad71488ee2b31d98a7",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "983",
    "commit-sha": "b9096afeae2f3c1aac3aabc1c5f78f6806840170",
    "pipeline": "master"
  }
]
0xmchadha commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1604",
    "commit-sha": "a5e69aa277e3c8e79d3bccad71488ee2b31d98a7",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "983",
    "commit-sha": "b9096afeae2f3c1aac3aabc1c5f78f6806840170",
    "pipeline": "master"
  }
]
0xmchadha commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1604",
    "commit-sha": "95de8beef21cda01d499d4605efd0878527b99f8",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "983",
    "commit-sha": "b9096afeae2f3c1aac3aabc1c5f78f6806840170",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "gaia",
    "pr-id": "458",
    "commit-sha": "c17abba71e50c11f1c96f6c9dbe3a11e35f96ad5",
    "pipeline": "master"
  }
]
codecov[bot] commented 4 years ago

Codecov Report

Merging #983 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #983      +/-   ##
==========================================
+ Coverage   54.82%   54.83%   +<.01%     
==========================================
  Files         124      124              
  Lines       11980    11982       +2     
==========================================
+ Hits         6568     6570       +2     
  Misses       4784     4784              
  Partials      628      628
Impacted Files Coverage Δ
controller/pkg/pucontext/puerrors.go 88.57% <ø> (ø) :arrow_up:
...ller/internal/enforcer/nfqdatapath/datapath_tcp.go 53.3% <100%> (+0.14%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 93ac69b...6c61bac. Read the comment docs.

0xmchadha commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "983",
    "commit-sha": "b9096afeae2f3c1aac3aabc1c5f78f6806840170",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "gaia",
    "pr-id": "458",
    "commit-sha": "c17abba71e50c11f1c96f6c9dbe3a11e35f96ad5",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1604",
    "commit-sha": "95de8beef21cda01d499d4605efd0878527b99f8",
    "pipeline": "master"
  }
]
0xmchadha commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1604",
    "commit-sha": "95de8beef21cda01d499d4605efd0878527b99f8",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "983",
    "commit-sha": "b9096afeae2f3c1aac3aabc1c5f78f6806840170",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "gaia",
    "pr-id": "458",
    "commit-sha": "c17abba71e50c11f1c96f6c9dbe3a11e35f96ad5",
    "pipeline": "master"
  }
]
0xmchadha commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1604",
    "commit-sha": "95de8beef21cda01d499d4605efd0878527b99f8",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "983",
    "commit-sha": "b9096afeae2f3c1aac3aabc1c5f78f6806840170",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "gaia",
    "pr-id": "458",
    "commit-sha": "c17abba71e50c11f1c96f6c9dbe3a11e35f96ad5",
    "pipeline": "master"
  }
]
0xmchadha commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1604",
    "commit-sha": "95de8beef21cda01d499d4605efd0878527b99f8",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "983",
    "commit-sha": "b9096afeae2f3c1aac3aabc1c5f78f6806840170",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "gaia",
    "pr-id": "458",
    "commit-sha": "09f9d5a283c77636087a874a38d40a6dfbdfe786",
    "pipeline": "master"
  }
]
0xmchadha commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1604",
    "commit-sha": "95de8beef21cda01d499d4605efd0878527b99f8",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "983",
    "commit-sha": "b9096afeae2f3c1aac3aabc1c5f78f6806840170",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "gaia",
    "pr-id": "458",
    "commit-sha": "09f9d5a283c77636087a874a38d40a6dfbdfe786",
    "pipeline": "master"
  }
]
aporeto-bot commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1604",
    "commit-sha": "95de8beef21cda01d499d4605efd0878527b99f8",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "983",
    "commit-sha": "b9096afeae2f3c1aac3aabc1c5f78f6806840170",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "gaia",
    "pr-id": "458",
    "commit-sha": "09f9d5a283c77636087a874a38d40a6dfbdfe786",
    "pipeline": "master"
  }
]
0xmchadha commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1604",
    "commit-sha": "976810f6c8a139dfadca1e4f1af89673f40439a1",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "983",
    "commit-sha": "b9096afeae2f3c1aac3aabc1c5f78f6806840170",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "gaia",
    "pr-id": "458",
    "commit-sha": "09f9d5a283c77636087a874a38d40a6dfbdfe786",
    "pipeline": "master"
  }
]
0xmchadha commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1604",
    "commit-sha": "976810f6c8a139dfadca1e4f1af89673f40439a1",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "983",
    "commit-sha": "b9096afeae2f3c1aac3aabc1c5f78f6806840170",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "gaia",
    "pr-id": "458",
    "commit-sha": "09f9d5a283c77636087a874a38d40a6dfbdfe786",
    "pipeline": "master"
  }
]
0xmchadha commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1604",
    "commit-sha": "06305f3c66796de1773aa8c0b4c98da970709223",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "983",
    "commit-sha": "b9096afeae2f3c1aac3aabc1c5f78f6806840170",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "gaia",
    "pr-id": "458",
    "commit-sha": "09f9d5a283c77636087a874a38d40a6dfbdfe786",
    "pipeline": "master"
  }
]
0xmchadha commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1604",
    "commit-sha": "06305f3c66796de1773aa8c0b4c98da970709223",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "983",
    "commit-sha": "b9096afeae2f3c1aac3aabc1c5f78f6806840170",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "gaia",
    "pr-id": "458",
    "commit-sha": "09f9d5a283c77636087a874a38d40a6dfbdfe786",
    "pipeline": "master"
  }
]
0xmchadha commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1604",
    "commit-sha": "06305f3c66796de1773aa8c0b4c98da970709223",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "983",
    "commit-sha": "b9096afeae2f3c1aac3aabc1c5f78f6806840170",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "gaia",
    "pr-id": "458",
    "commit-sha": "09f9d5a283c77636087a874a38d40a6dfbdfe786",
    "pipeline": "master"
  }
]
0xmchadha commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "gaia",
    "pr-id": "458",
    "commit-sha": "09f9d5a283c77636087a874a38d40a6dfbdfe786",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1604",
    "commit-sha": "06305f3c66796de1773aa8c0b4c98da970709223",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "983",
    "commit-sha": "b9096afeae2f3c1aac3aabc1c5f78f6806840170",
    "pipeline": "master"
  }
]
0xmchadha commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "gaia",
    "pr-id": "458",
    "commit-sha": "09f9d5a283c77636087a874a38d40a6dfbdfe786",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1604",
    "commit-sha": "06305f3c66796de1773aa8c0b4c98da970709223",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "983",
    "commit-sha": "b9096afeae2f3c1aac3aabc1c5f78f6806840170",
    "pipeline": "master"
  }
]
0xmchadha commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "983",
    "commit-sha": "6c61bac08599db5513e2b328da48c1225e624026",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "gaia",
    "pr-id": "458",
    "commit-sha": "09f9d5a283c77636087a874a38d40a6dfbdfe786",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1604",
    "commit-sha": "06305f3c66796de1773aa8c0b4c98da970709223",
    "pipeline": "master"
  }
]