aporeto-inc / trireme-lib

Simple, scalable and secure application segmentation
https://trireme.io
Apache License 2.0
299 stars 51 forks source link

Dup ack rel3.13 #988

Closed 0xmchadha closed 4 years ago

0xmchadha commented 4 years ago

Description

Changes proposed in this pull request.

Test plan

Outline the test plan used to test this change before merging it.

Fixes #.

codecov[bot] commented 4 years ago

Codecov Report

Merging #988 into release-3.13.0 will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-3.13.0     #988      +/-   ##
==================================================
+ Coverage           57.76%   57.76%   +<.01%     
==================================================
  Files                 112      112              
  Lines               11385    11387       +2     
==================================================
+ Hits                 6576     6578       +2     
  Misses               4191     4191              
  Partials              618      618
Impacted Files Coverage Δ
controller/pkg/pucontext/puerrors.go 88.57% <ø> (ø) :arrow_up:
...ller/internal/enforcer/nfqdatapath/datapath_tcp.go 60.75% <100%> (+0.12%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4086819...94d33b1. Read the comment docs.

0xmchadha commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "988",
    "commit-sha": "22623cca5973d70a7138ecffc4b0073fcb59f8ad",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "gaia",
    "pr-id": "459",
    "commit-sha": "5da7d48821bad9a664b8ce2030d2a4ea3d975e43",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1609",
    "commit-sha": "b66c9f9300e1201d22cdf3a36e37927ea8900345",
    "pipeline": "master"
  }
]
0xmchadha commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1609",
    "commit-sha": "ec57f7a68b0848e08d5466366eb37c30dda426c1",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "988",
    "commit-sha": "94d33b15be7edb8b3432a508b7afc5d53eb4f15a",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "gaia",
    "pr-id": "459",
    "commit-sha": "5da7d48821bad9a664b8ce2030d2a4ea3d975e43",
    "pipeline": "master"
  }
]
0xmchadha commented 4 years ago

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "988",
    "commit-sha": "94d33b15be7edb8b3432a508b7afc5d53eb4f15a",
    "pipeline": "release-3.13.0"
  },
  {
    "project": "",
    "component": "gaia",
    "pr-id": "459",
    "commit-sha": "5da7d48821bad9a664b8ce2030d2a4ea3d975e43",
    "pipeline": "release-3.13.0"
  },
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1609",
    "commit-sha": "ec57f7a68b0848e08d5466366eb37c30dda426c1",
    "pipeline": "release-3.13.0"
  }
]