aporia-ai / mlnotify

🔔 No need to keep checking your training - just one import line and you'll know the second it's done.
https://mlnotify.aporia.com
MIT License
344 stars 19 forks source link

[BUG] If a task is interrupted before mlnotify.end() is called, it runs forver #48

Closed dcizin closed 2 years ago

dcizin commented 2 years ago

I had to kill a task since it was going to take too long - mltnoify will run forever unless I remember to manually call mlnotify.end(). Forgetting to call end() also prevents me from calling start() - it prints the warning "before hook was already called", which is not the most informative and doesn't tell me that it actually failed to start a new counter. Maybe it should suggest calling mlnotify.end() instead?

SnirShechter commented 2 years ago

Duplicate of #11