apostrophecms-legacy / apostrophe-map

MIT License
1 stars 1 forks source link

Hard-coded browser API key and upcoming restrictions #10

Open abea opened 6 years ago

abea commented 6 years ago

I noticed there's a hard-coded API key for the client-side map production. There's not an indication of what Google account that belongs to and I'm concerned that it could run into the upcoming change where Google is requiring billing accounts for mapping API usage.

Do we know we're covered in that area?

CC @boutell

boutell commented 6 years ago

This key was added to apostrophe-map by a P'unk who has long departed and his google account no longer exists. In my estimation we're not going to get billed for it somehow or we would have been already since it got committed publicly (ugh).

If real, working keys are needed in projects of that vintage to support google maps after the billing requirement kicks in this month, then this code will need to be changed to take that key as configuration.

On Tue, Jun 12, 2018 at 11:54 AM, Alex Bea notifications@github.com wrote:

I noticed there's a hard-coded API key https://github.com/apostrophecms-legacy/apostrophe-map/blob/master/public/js/content.js#L60 for the client-side map production. There's not an indication of what Google account that belongs to and I'm concerned that it could run into the upcoming change where Google is requiring billing accounts for mapping API usage.

Do we know we're covered in that area?

CC @boutell https://github.com/boutell

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/apostrophecms-legacy/apostrophe-map/issues/10, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB9fZA3TwjpDYcX5YCow2W9w1ern2VLks5t7-QqgaJpZM4UktOJ .

--

THOMAS BOUTELL, CHIEF SOFTWARE ARCHITECT P'UNK AVENUE | (215) 755-1330 | punkave.com