search

apostrophecms-legacy / apostrophe-ui-2

DEPRECATED - FOR 0.5.x ONLY. CSS for an OLD version of Apostrophe, NOT for new work.
0 stars 0 forks source link

Error on minification #3

Open novascreen opened 10 years ago

novascreen commented 10 years ago

Error: .apos-ui-dropdown-container is undefined

this is the error i get when turning on minification, must have happened in version 0.5.10

novascreen commented 10 years ago

actually the full error is this:

...\node_modules\apostrophe-site\index.js:546
      throw err;
            ^
Error: .apos-ui-dropdown-item is undefined

and i tried going back to 0.5.9 and it didn't fix it, i just created the issue here because this is the module where that mixin is created

jsumnersmith commented 10 years ago

Thanks for bringing this up! I was fixing some bugginess with all the z-index of menus this morning. In particular, we were making some important changes to the apostrophe-blocks module.

Without minification, we were getting cross-module LESS mixins to work. Looks like that's an issue on minification, however.

I've patched a fix and pushed/published it for apostrophe-blocks. That should take care of the issue for now. Update that module, and all should be well.

The real bug here seems to be that cross-module LESS breaks down on minification. I'll leave this open until we can solve that.

boutell commented 10 years ago

Joel, I am able to reset the apos base color at the end of site.less with and without minification. It seems to be working properly.

On Thu, May 1, 2014 at 1:08 PM, Joel Smith notifications@github.com wrote:

Thanks for bringing this up! I was fixing some bugginess with all the z-index of menus this morning. In particular, we were making some important changes to the apostrophe-blocks module.

Without minification, we were getting cross-module LESS mixins to work. Looks like that's an issue on minification, however.

I've patched a fix and pushed/published it for apostrophe-blocks. That should take care of the issue for now. Update that module, and all should be well.

The real bug here seems to be that cross-module LESS breaks down on minification. I'll leave this open until we can solve that.

— Reply to this email directly or view it on GitHubhttps://github.com/punkave/apostrophe-ui-2/issues/3#issuecomment-41931017 .

Tom Boutell Lead Developer P'unk Avenue 215 755 1330 punkave.com window.punkave.com

novascreen commented 10 years ago

always so quick, thanks Joel good to see you addressing the z-index issues, you did an awesome job on the UI and everybody here loves it. we are using Drupal a lot and this blew peoples mind ;) hopefully we'll be using Apostrophe a lot more from now on

jsumnersmith commented 10 years ago

Tom,

Just to follow up, the problem was with Apostrophe Blocks. That was the only minification error that was coming through.

boutell commented 10 years ago

OK, show me this one Monday

On Sat, May 3, 2014 at 2:18 PM, Joel Smith notifications@github.com wrote:

Tom,

Just to follow up, the problem was with Apostrophe Blocks. That was the only minification error that was coming through.

— Reply to this email directly or view it on GitHubhttps://github.com/punkave/apostrophe-ui-2/issues/3#issuecomment-42112402 .

Tom Boutell Lead Developer P'unk Avenue 215 755 1330 punkave.com window.punkave.com