boutell
commented
6 years ago def is false, this change should not be necessary. However I'll check it in headless since that is obviously not your experience (:
On Thu, Feb 1, 2018 at 12:06 PM, blaineo notifications@github.com wrote:
This will set the future variable to false. I don't see any recourse. It helps reduce required request variables when using this module in combination with apostrophe-headless and this module.
If this does cause an unforeseen issue, I have yet to encounter it.
Without this change requests to the api require a future param: /api/v1/apostrophe-blog?future=false/true
With this change, the base url will return blog articles not in the future with: /api/v1/apostrophe-blog
You can view, comment on, or merge this pull request online at:
https://github.com/apostrophecms/apostrophe-blog/pull/20 Commit Summary
- chore(setting future to default as false )
File Changes
- M lib/cursor.js https://github.com/apostrophecms/apostrophe-blog/pull/20/files#diff-0 (6)
Patch Links:
- https://github.com/apostrophecms/apostrophe-blog/pull/20.patch
- https://github.com/apostrophecms/apostrophe-blog/pull/20.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/apostrophecms/apostrophe-blog/pull/20, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB9ffHaRA_8RuCuTEynGHgMLqJpxHhbks5tQe8vgaJpZM4R19XT .
--
THOMAS BOUTELL, CHIEF SOFTWARE ARCHITECT P'UNK AVENUE | (215) 755-1330 | punkave.com
abea
This will set the future variable to false. I don't see any recourse. It helps reduce required request variables when using this module in combination with apostrophe-headless and this module.
If this does cause an unforeseen issue, I have yet to encounter it.
Without this change requests to the api require a future param:
/api/v1/apostrophe-blog?future=false/trueWith this change, the base url will return blog articles not in the future with:
/api/v1/apostrophe-blog