Node.js version in Dockerfile

[ghost]

During environment setup, the latest Node.js version will be installed.

I was wondering why there is a specific Node version specified in the Dockerfile? Isn't it better to just pull the node image instead of node:<version>? No need to constantly update the version.

[boutell]

Probably! Would you like to do a PR?

On Tue, May 15, 2018 at 2:40 PM, Carsten notifications@github.com wrote:

During environment setup https://apostrophecms.org/docs/tutorials/getting-started/setting-up-your-environment.html, the latest Node.js version will be installed.

I was wondering why there is a specific Node version specified in the Dockerfile? Isn't it better to just pull the node image instead of node:? No need to constantly update the version.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/apostrophecms/apostrophe-boilerplate/issues/8, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB9fZQyLyguZ2RWdsW-vSlax2Nucc8fks5tyyESgaJpZM4UAEUA .

--

THOMAS BOUTELL, CHIEF SOFTWARE ARCHITECT P'UNK AVENUE | (215) 755-1330 | punkave.com

[ghost]

Done! #9

[boutell]

I think LTS might make more sense here.

On Thu, May 17, 2018 at 12:30 PM, Carsten notifications@github.com wrote:

9 https://github.com/apostrophecms/apostrophe-boilerplate/pull/9

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/apostrophecms/apostrophe-boilerplate/issues/8#issuecomment-389928396, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB9fZBjuiVzo-psB9t5VhunJ_1myYnOks5tzaW3gaJpZM4UAEUA .

--

THOMAS BOUTELL, CHIEF SOFTWARE ARCHITECT P'UNK AVENUE | (215) 755-1330 | punkave.com

[ghost]

So, you recommend to install LTS locally, too? According to the tutorial, the local dev environment will be set up on latest Node.

When the developer installs latest Node.js locally, uses features of that version and then creates a Docker image based on an older Node.js (LTS) version, wouldn't this create conflicts?

[boutell]

The tutorial recommends to install node with homebrew, it doesn't recommend a version. But here we have to express an opinion, and I think lts is a sensible opinion to express, since nodejs.org says the LTS is "recommended for most users."

On Thu, May 17, 2018 at 1:40 PM, Carsten notifications@github.com wrote:

So, you recommend to install LTS locally, too? According to the tutorial https://apostrophecms.org/docs/tutorials/getting-started/setting-up-your-environment.html, the local dev environment will be set up on latest Node.

When the developer installs latest Node.js locally, uses features of that version and then creates a Docker image based on an older Node.js (LTS) version, wouldn't this create conflicts?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/apostrophecms/apostrophe-boilerplate/issues/8#issuecomment-389949665, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB9fcdyheiVBE8At3EsIOyb5gtOY4zrks5tzbYlgaJpZM4UAEUA .

--

THOMAS BOUTELL, CHIEF SOFTWARE ARCHITECT P'UNK AVENUE | (215) 755-1330 | punkave.com

[ghost]

I get the point that latest versions are not always great for production. And I think the developer is sensible enough to check requirements of the app before dockerizing. 😆

Edit: PR #9 updated.