search

apostrophecms / apostrophe-cli

DEPRECATED. Use `@apostrophecms/cli` as the active ApostropheCMS CLI tool.
https://www.npmjs.com/package/@apostrophecms/cli
14 stars 5 forks source link

Adds analytics and user conf #32

Closed abea closed 3 years ago

abea commented 4 years ago

Adds some basic usage tracking, with support of added user configuration.

Also closes #25 and #35

abea commented 4 years ago

Any red flags yet?

abea commented 4 years ago

We're not merging into master just yet, to not load this one PR up with too much that should be deployed in that release.

boutell commented 4 years ago

I wanted to say, since I raised concerns and it might not be otherwise clear: this is very good work.

abea commented 4 years ago

@localghost443 See https://github.com/apostrophecms/apostrophe-cli/pull/32/commits/8ff56fb8f9d537b7a2553fe18d06894734b2a423.

Are there any blockers to getting this merged for the next release?

abea commented 4 years ago

Another example of CLI usage tracking: https://github.com/nuxt/telemetry