apostrophecms / apostrophe-documentation

Documentation for the ApostroheCMS open-souce ecosystem
https://docs.apostrophecms.org/
MIT License
25 stars 46 forks source link

[DOCS ISSUE] Page: Page Templates #302

Open pwohlschl opened 4 years ago

pwohlschl commented 4 years ago

The documentation invites to edit "app.js", when actually the file to update is the relevant "index.js".

abea commented 4 years ago

Are you referring to "### Example: Adding a Page Template to app.js"? That is true, but not the best practice. I'll update that. Please let me know if you're talking about another specific reference.

abea commented 4 years ago

Also "2. Register the new page template in app.js". The same applies but, again, it's not the best practice anymore.

pwohlschl commented 4 years ago

Correct, I first came across this issue whilst going through the tutorials online. I spotted it on a few occasions on "Page Templates":

I think this change in best practice might have impacted other parts of the documentation, e.g. in the "Building Navigation" pages, I also read "first, in app.js, let's configure apostrophe-pages to retrieve two levels of children when fetching ancestors of the current page".