apostrophecms / apostrophe-documentation

Documentation for the ApostroheCMS open-souce ecosystem
https://docs.apostrophecms.org/
MIT License
25 stars 46 forks source link

Pro 1805 pieces fix #379

Closed abea closed 3 years ago

abea commented 3 years ago

Fixes people page module name reference to be consistent with A2 best practices.

Also resolves #297

linear[bot] commented 3 years ago
PRO-1805 Documentation error: "When working on Pieces, pieces pages and pieces-widgets section I think I found an error in the A2 documentation about pieces pages"

From Val: When working on Pieces, pieces pages and pieces-widgets section I think I found an error in the A2 documentation about pieces pages.\ [https://v2.docs.apostrophecms.org/core-concepts/reusable-content-pieces/browsing-directory-of-pieces.html#displaying-a-direct\[…\]strophe-pieces-pages](https://v2.docs.apostrophecms.org/core-concepts/reusable-content-pieces/browsing-directory-of-pieces.html#displaying-a-direct\[…\]strophe-pieces-pages) ``` // app.js modules: {  // ... other modules ...,  'apostrophe-pages': {    types: [      // Ordinary page types      {        name: 'default',        label: 'Default'      },      {        name: 'home',        label: 'Home'      },      // Our new page type for displaying people      {        name: 'people-pages',        label: 'People'      }    ]  } } ``` It should be `people-page`  and not `people-pages` otherwise it doesn't work.\ If you validate I can modify the doc.