Directory reference can break if another module improves apos-forms

apostrophecms / apostrophe-forms-submit-google

Google sheets submission for Apostrophe Forms

MIT License

1 stars 2 forks source link

Directory reference can break if another module improves apos-forms #3

Open abea opened 5 years ago

abea commented 5 years ago

https://github.com/apostrophecms/apostrophe-forms-submit-google/blob/4a6f31f9e7ff42721661544bae68b2a603658407/index.js#L134

If another module improves apostrophe-forms, this will break because it will no longer be at the end of the chain.

boutell commented 4 years ago

Actually the issue is a documentation one, project level lib/modules/apostrophe-forms (not lib/modules/apostrophe-forms-submit-google) is always the end of the chain, but our docs say to use the latter, which is never consulted. See PR.