search

apostrophecms / apostrophe-redirects

Allows admins to create redirects within an Apostrophe site
2 stars 2 forks source link

Querystring filter #24

Closed shaunhurley closed 3 years ago

shaunhurley commented 3 years ago

Tom,

Working optional querystring filter code as discussed in issue #23

Added a new field to the redirect definition called ignoreQUerystring and the rest of it is pretty much in line with your suggestions.

Cheers,

Shaun

shaunhurley commented 3 years ago

Code updated and changes pushed, should be all good.

boutell commented 3 years ago

Thanks for the contribution! This should come out in our next release cycle (2 weeks).

abea commented 3 years ago

Is there new functionality here that should be covered in the README?

shaunhurley commented 3 years ago

Oops, that's embarrassing - I didn't push up the README edit. Tom, do you want/need me to do a new pull request for that?

"By default a redirect includes any query string on incoming requests when matching for redirection. You can toggle the 'Ignore query string when matching.' option to ignore query strings on requests and only match on the base URL path."

boutell commented 3 years ago

D'oh, I missed it too! Would you mind Shaun? Thanks.

On Wed, Feb 10, 2021 at 12:08 PM Shaun Hurley notifications@github.com wrote:

Oops, that's embarrassing - I didn't push up the README edit. Tom, do you want/need me to do a new pull request for that?

"By default a redirect includes any query string on incoming requests when matching for redirection. You can toggle the 'Ignore query string when matching.' option to ignore query strings on requests and only match on the base URL path."

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/apostrophecms/apostrophe-redirects/pull/24#issuecomment-776866949, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAH27OTTXN5UVRH4JBQO6TS6K4QLANCNFSM4XL5G3BA .

--

THOMAS BOUTELL | CHIEF TECHNOLOGY OFFICER APOSTROPHECMS | apostrophecms.com | he/him/his