search

apostrophecms / apostrophe-salesforce-experience

Customize your website's appearance based on the user's Salesforce account
MIT License
0 stars 0 forks source link

Remove unnecessary route step #13

Open abea opened 5 years ago

abea commented 5 years ago

https://github.com/apostrophecms/apostrophe-salesforce-experience/blob/62e22f8cb49b2c43b58d554e25f7d0bd06f7bf8e/lib/modules/apostrophe-salesforce-connect/index.js#L108

@boutell What do you think here? SAML should be hitting the getCallbackPath URL on its way back, so that step should never be seen.

boutell commented 5 years ago

I'm not sure, there might be a session based mechanism that brings them back here after all. I'd test it with some logging.

On Wed, Jun 12, 2019 at 4:32 PM Alex Bea notifications@github.com wrote:

https://github.com/apostrophecms/apostrophe-salesforce-experience/blob/62e22f8cb49b2c43b58d554e25f7d0bd06f7bf8e/lib/modules/apostrophe-salesforce-connect/index.js#L108

@boutell https://github.com/boutell What do you think here? SAML should be hitting the getCallbackPath URL on its way back, so that step should never be seen.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/apostrophecms/apostrophe-salesforce-experience/issues/13?email_source=notifications&email_token=AAAH27NM7TJDH3HVOKDZBILP2FMODA5CNFSM4HXRMDAKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GZFAXEA, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAH27OY5IHPIUGGBXUHEATP2FMODANCNFSM4HXRMDAA .

--

Thomas Boutell, Chief Software Architect P'unk Avenue | (215) 755-1330 | punkave.com