search

apostrophecms / apostrophe-salesforce-experience

Customize your website's appearance based on the user's Salesforce account
MIT License
0 stars 0 forks source link

Make `userLabelField` optional #6

Open abea opened 5 years ago

abea commented 5 years ago

https://github.com/apostrophecms/apostrophe-salesforce-experience/blob/237a741b8577c18c1fc4ba313cfd03eb44351c49/lib/getExperiences.js#L81

I'm not sure we really use this value. We should make it truly optional and fall back to the userIdField value if missing. I think the end user would only ever see the labelField value from the general query.

CC @boutell

boutell commented 5 years ago

I see why that is. Yes you can remove it entirely I think.

On Tue, May 28, 2019 at 12:00 PM Alex Bea notifications@github.com wrote:

https://github.com/apostrophecms/apostrophe-salesforce-experience/blob/237a741b8577c18c1fc4ba313cfd03eb44351c49/lib/getExperiences.js#L81

I'm not sure we really use this value. We should make it truly optional and fall back to the userIdField value if missing. I think the end user would only ever see the labelField value from the general query.

CC @boutell https://github.com/boutell

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/apostrophecms/apostrophe-salesforce-experience/issues/6?email_source=notifications&email_token=AAAH27MUDSVBGIJIMLJ26Y3PXVJJFA5CNFSM4HQE3ULKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GWISPFA, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAH27LWR3SMHHADTHQ4T3LPXVJJFANCNFSM4HQE3ULA .

--

Thomas Boutell, Chief Software Architect P'unk Avenue | (215) 755-1330 | punkave.com