apostrophecms / apostrophe-sandbox

This sandbox site is the basis for our live demo. For your own projects, you can use apostrophe-boilerplate as a more streamlined, cleaner point of departure via the apostrophe-cli tool.
MIT License
112 stars 41 forks source link

CSS missing #29

Closed fotisp closed 10 years ago

fotisp commented 10 years ago

Hello,

On a fresh install of the apostrophe-sandbox on OSX I noticed the following in the Safari logs

[Error] Failed to load resource: the server responded with a status of 404 (Not Found) (editor.css, line 0)
[Error] Failed to load resource: the server responded with a status of 404 (Not Found) (editor.css, line 0)

I then checked the console to find this

Error: ENOENT, stat '/path_to_project/node_modules/apostrophe-ui-2/public/css/editor.css'
Error: ENOENT, stat '/path_to_project/node_modules/apostrophe-ui-2/public/css/editor.css'

So I am guessing it is either an issue in my file system, or an assumption in the code.

I just started getting into the code, so I cannot provide a more thorough explanation of why this is happening.

boutell commented 10 years ago

Hi Fotis, nice to see you using A2.

These are only warnings because the module is pushing an asset it doesn't actually have. All the CSS is actually in the content.less asset, at least for now.

In production this error would not show up in a browser because of minification, but we should still fix it so I will keep the ticket open.

On Mon, Feb 10, 2014 at 11:54 AM, Fotis Paraskevopoulos < notifications@github.com> wrote:

Hello,

On a fresh install of the apostrophe-sandbox on OSX I noticed the following in the Safari logs

[Error] Failed to load resource: the server responded with a status of 404 (Not Found) (editor.css, line 0) [Error] Failed to load resource: the server responded with a status of 404 (Not Found) (editor.css, line 0)

I then checked the console to find this

Error: ENOENT, stat '/path_to_project/node_modules/apostrophe-ui-2/public/css/editor.css' Error: ENOENT, stat '/path_to_project/node_modules/apostrophe-ui-2/public/css/editor.css'

So I am guessing it is either an issue in my file system, or an assumption in the code.

I just started getting into the code, so I cannot provide a more thorough explanation of why this is happening.

Reply to this email directly or view it on GitHubhttps://github.com/punkave/apostrophe-sandbox/issues/29 .

Tom Boutell Lead Developer P'unk Avenue 215 755 1330 punkave.com window.punkave.com

fotisp commented 10 years ago

Hi Tom,

Yes I am trying to get my head around it.

I think there is something else going on. For example, check out the attached picture, if you look carefully there are enough errors regarding ".png" files. This is visible on the corner where your logo is not visible.

This happens randomly, I haven't done anything special, other than look around :) I promise.

On the console, the node process crashes and restarts with no apparent error.

screen shot 2014-02-18 at 7 22 14 pm

Error: ENOENT, stat '/Volumes/Files/Development/node/tabakos.gr/node_modules/apostrophe-ui-2/public/css/editor.css'
DEBUG: crashing child
DEBUG: Starting child process with 'node app.js'
I see no data/port file, defaulting to port 3000
Listening on port 3000

I'll keep poking around anyways, if something comes up I will let you know

Cheers, Fotis

chrislaue commented 10 years ago

I ran across the same issue.

I cloned the sandbox, followed the startup steps including the apostrophe:reset.

Weird bit was when I first started the application - I got a MongoError mentioning duplicate index 'globals' AND the error:

Error: ENOENT, stat '/Users/cl/Apostrophe-sandbox/apostrophe-sandbox/node_modules/apostrophe-ui-2/public/css/editor.css'

With a corresponding 404 in the browser for that particular file as well.

I turfed the database and started from scratch and didn't get the MongoError - but still am getting the above error.

Doesn't seem to affect performance or any editing abilities (it IS just css after all), but I'm trying to understand if this is (possibly) a side effect of apostrophe-ui-2 being rolled into the apostrophe module (as mentioned on the projects home page)?

boutell commented 10 years ago

Sounds like a different issue actually Chris.

Some of our modules "push" asset files they don't actually have yet. This produces some annoying 404s, but only in a dev environment (where minify is not set to true in local.js), except for one at startup.

We should work on removing these unnecessary 404s by checking at startup whether these files at least exist.

What Fotis is reporting seems different. He has lots of "missing" image files. I put missing in quotes because the sandbox has all of them and I don't get any of those 404's.

It's as if he had somehow disabled all the static file serving stuff in Apostrophe, but I have to take his word for it that this is a brand new clone of our sandbox.

On Wed, Feb 26, 2014 at 6:11 PM, Chris Laue notifications@github.comwrote:

I ran across the same issue.

I cloned the sandbox, followed the startup steps including the apostrophe:reset.

Weird bit was when I first started the application - I got a MongoError mentioning duplicate index 'globals' AND the error:

Error: ENOENT, stat '/Users/cl/Apostrophe-sandbox/apostrophe-sandbox/node_modules/apostrophe-ui-2/public/css/editor.css'

With a corresponding 404 in the browser for that particular file as well.

I turfed the database and started from scratch and didn't get the MongoError - but still am getting the above error.

Doesn't seem to affect performance or any editing abilities (it IS just css after all), but I'm trying to understand if this is (possibly) a side effect of apostrophe-ui-2 being rolled into the apostrophe module (as mentioned on the projects home page)?

Reply to this email directly or view it on GitHubhttps://github.com/punkave/apostrophe-sandbox/issues/29#issuecomment-36189922 .

Tom Boutell Lead Developer P'unk Avenue 215 755 1330 punkave.com window.punkave.com

chrislaue commented 10 years ago

Tom,

Thanks for the explanation - I actually went into apostrophe-sandbox/node_modules/apostrophe-ui-2/public/css to see what was there and found content.{less,css} were there so figured I'd try renaming content.css to editor.css to fix the issue (in a less than ideal way) for now. Confusingly I realized there is editor.{less,css} in apostrophe-editor-2 which is also called - however from what I can tell it has it's own purpose outside of the editor.css expected from /apostrophe-ui-2/css

Still digging into Apostrophe so a tad fuzzy on the interplay of all the modules and apologize if I've derailed this particular issue.

boutell commented 10 years ago

You definitely don't want to rename those things (:

Please just tolerate the 404's they are not hurting you and they will not show up in browsers in production.

We'll work on addressing them though because it clearly causes confusion.

On Wed, Feb 26, 2014 at 9:01 PM, Chris Laue notifications@github.comwrote:

Tom,

Thanks for the explanation - I actually went into apostrophe-sandbox/node_modules/apostrophe-ui-2/public/css to see what was there and found content.{less,css} were there so figured I'd try renaming content.css to editor.css to fix the issue (in a less than ideal way) for now. Confusingly I realized there is editor.{less,css} in apostrophe-editor-2 which is also called - however from what I can tell it has it's own purpose outside of the editor.css expected from /apostrophe-ui-2/css

Still digging into Apostrophe so a tad fuzzy on the interplay of all the modules and apologize if I've derailed this particular issue.

Reply to this email directly or view it on GitHubhttps://github.com/punkave/apostrophe-sandbox/issues/29#issuecomment-36202216 .

Tom Boutell Lead Developer P'unk Avenue 215 755 1330 punkave.com window.punkave.com

boutell commented 10 years ago

Feel free to chime in on the github issue so you hear about it when it's fixed:

https://github.com/punkave/apostrophe/issues/88

But again, this isn't hurting anything.

On Wed, Feb 26, 2014 at 9:45 PM, Tom Boutell tom@punkave.com wrote:

You definitely don't want to rename those things (:

Please just tolerate the 404's they are not hurting you and they will not show up in browsers in production.

We'll work on addressing them though because it clearly causes confusion.

On Wed, Feb 26, 2014 at 9:01 PM, Chris Laue notifications@github.comwrote:

Tom,

Thanks for the explanation - I actually went into apostrophe-sandbox/node_modules/apostrophe-ui-2/public/css to see what was there and found content.{less,css} were there so figured I'd try renaming content.css to editor.css to fix the issue (in a less than ideal way) for now. Confusingly I realized there is editor.{less,css} in apostrophe-editor-2 which is also called - however from what I can tell it has it's own purpose outside of the editor.css expected from /apostrophe-ui-2/css

Still digging into Apostrophe so a tad fuzzy on the interplay of all the modules and apologize if I've derailed this particular issue.

Reply to this email directly or view it on GitHubhttps://github.com/punkave/apostrophe-sandbox/issues/29#issuecomment-36202216 .

Tom Boutell Lead Developer P'unk Avenue 215 755 1330 punkave.com window.punkave.com

Tom Boutell Lead Developer P'unk Avenue 215 755 1330 punkave.com window.punkave.com

boutell commented 10 years ago

This is fixed.

fotisp commented 10 years ago

Thanks Tom!