apostrophecms / apostrophe-tiptap-rich-text-widgets

Wrapper allowing the use of the tiptap vue-based rich-text editor for Apostrophe 2.x. In 3.x it will be standard equipment.
6 stars 1 forks source link

Pin ApostropheWindow to it's contextual home #9

Open stuartromanek opened 5 years ago

stuartromanek commented 5 years ago

I think it would be clearer if when your were editing a Link's properties, the ApostropheWindow component would pin to the selection rather than the toolbar.

image

There is a tiptap demo where a bubble menu element receives the x,y coords of the highlighted element. Can we use this?

https://tiptap.scrumpy.io/menu-bubble

boutell commented 5 years ago

I... don't think so. I think this feature is specifically offered for a popup menu that's coming up while the selection is still active, not during a button press in a toolbar that is outside of it. But, I could be wrong; might be worth playing with.

On Mon, Jul 1, 2019 at 10:14 PM Stuart Romanek notifications@github.com wrote:

I think it would be clearer if when your were editing a Link's properties, the ApostropheWindow component would pin to the selection rather than the toolbar.

[image: image] https://user-images.githubusercontent.com/1889830/60477479-5260c800-9c4d-11e9-8ea8-c828b20218ea.png

There is a tiptap demo where a bubble menu element receives the x,y coords of the highlighted element. Can we use this?

https://tiptap.scrumpy.io/menu-bubble

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/apostrophecms/apostrophe-tiptap-rich-text-widgets/issues/9?email_source=notifications&email_token=AAAH27KPLPFBYX6ZMTBJSUTP5K2X5A5CNFSM4H4XLGJKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G4YTPXQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAH27MXKUODVDC2O7BL4SDP5K2X5ANCNFSM4H4XLGJA .

--

Thomas Boutell, Chief Software Architect P'unk Avenue | (215) 755-1330 | punkave.com

boutell commented 5 years ago

This could prove very important when editing a tall rich text widget.

boutell commented 5 years ago

I think you're right about menu-bubble, provided your tools are all contained by it.