'rank' seems to be miscalculated when committing page

apostrophecms / apostrophe-workflow

Provides approval-based workflow and localization capabilities for projects that need them. An optional component of the Apostrophe CMS.

MIT License

36 stars 20 forks source link

'rank' seems to be miscalculated when committing page #285

Closed Labcup closed 4 years ago

Labcup commented 5 years ago

Hello,

as far as I understand, the 'rank' of a page gets modified when you drag it around in the Pages Module interface. Correct? In Draft mode, the order of the pages in my header navigation always corresponds with the order in the Module. However, the order is different in Live mode after committing the pages. I also compared the 'rank' of both Live and Draft versions of the pages in the database and they indeed differ from eachother.

I noticed that 'rank' is included in baseExcludeProperties by default and it seems to get recalculated. Why is this the case? Because when I override baseExcludeProperties and leave 'rank' out, everything works as expected – Live and Draft versions look identical.

BTW, I also had one severe occasion where the 'level' seemed to be miscalculated as well and the pages were all on the same level.

boutell commented 5 years ago

Got a simple test case? For instance, a series of steps with this project:

http://github.com/apostrophecms/apostrophe-enterprise-testbed

boutell commented 4 years ago

What version of apostrophe-workflow did this occur with? Is it still happening?

Labcup commented 4 years ago

It happened with apostrophe-workflow 2.26.0. Didn't happen again in our project so far. I'll provide a test case for you soon.

Labcup commented 4 years ago

@boutell How do I use the testbed exactly? ~~Currently it gives me test/minify: line 12: wget: command not found.~~ Ran brew install wget and got it working. ;-)

Labcup commented 4 years ago

I haven't been able to reproduce the problem so far.

boutell commented 4 years ago

Were you trying to run npm test?

It was looking for the wget utility, which you presumably don't have.

But you can also just use it as a project to test things in with the ordinary "node app".

On Fri, Nov 22, 2019 at 7:40 AM Labcup notifications@github.com wrote:

I havent't been able to reproduce the problem so far.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/apostrophecms/apostrophe-workflow/issues/285?email_source=notifications&email_token=AAAH27PKRYWNK5ZG6QB5ZWTQU7HNRA5CNFSM4JKF53Z2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE5QTPQ#issuecomment-557517246, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAH27NUEF6UKWFQCJUWKCLQU7HNRANCNFSM4JKF53ZQ .

THOMAS BOUTELL | CHIEF TECHNOLOGY OFFICER APOSTROPHECMS | apostrophecms.com | he/him/his

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.