search

apostrophecms / apostrophe

A full-featured, open-source content management framework built with Node.js that empowers organizations by combining in-context editing and headless architecture in a full-stack JS environment.
https://apostrophecms.com
Other
4.36k stars 590 forks source link

Enhancement to showFields on arrangeFields tab grouping #1236

Closed austinstarin closed 4 years ago

austinstarin commented 6 years ago

If show fields on a group of arranged fields in your schema, the fields show/hide but the tab that you group them in remains.

boutell commented 6 years ago

Interesting point, but can you have a ux convo first with @stuartromanek about whether we should be showing and hiding tabs with showFields? The user night miss that even if it worked.

On Feb 13, 2018 4:15 AM, "Austin Starin" notifications@github.com wrote:

If show fields on a group of arranged fields in your schema, the fields show/hide but the tab that you group them in remains.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/apostrophecms/apostrophe/issues/1236, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB9fXAsiaZ7VQj0jAbR4ZBW3q7UvlwFks5tUXzXgaJpZM4SDqPQ .

bobclewell commented 6 years ago

I just came across this need in my current project.

To me it would be more confusing to have an empty tab, then to hide and show tabs. I going to work with the empty tabs for now.

bobclewell commented 6 years ago

Simply stated, if the tab has no fields within it showing, it should also be hidden, IMO.

boutell commented 6 years ago

Works for me.

boutell commented 6 years ago

(That is, the idea works for me.)

stuartromanek commented 4 years ago

There is a semi-duplicate where I suggested visually disabling those tabs, which feels more in line with something like a system menu. That seems like the better option to me but would hear from @boutell and @bobclewell before closing this one

stuartromanek commented 4 years ago

that issue is here https://github.com/apostrophecms/apostrophe/issues/1398

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.