search

apostrophecms / apostrophe

A full-featured, open-source content management framework built with Node.js that empowers organizations by combining in-context editing and headless architecture in a full-stack JS environment.
https://apostrophecms.com
Other
4.36k stars 590 forks source link

Move to Sass in core #1606

Closed abea closed 4 years ago

abea commented 6 years ago

Arguments here are going to end up somewhat subjective, but there is good evidence behind it, including:

Subjectively, Sass seems to have the momentum behind it and is the standard for preprocessors. This would be the opportunity before a 4.x to get the default asset compiler switched (other than adding an option for either).

houmark commented 6 years ago

+1 for Sass... please, it's maybe the only thing I don't like about Apostrophe currently.

stuartromanek commented 6 years ago

Sass by default will be part of apostrophe 3's new asset pipeline, project issue here https://github.com/apostrophecms/apostrophe/issues/1574

boutell commented 6 years ago

Actually #1574 just says we'll evaluate the CSS compilation strategy, and I thought there were some newer things we wanted to at least peek at first before committing? Not that I'm looking for new scope or new trouble here, the popularity of SASS seems to be enduring...

On Mon, Aug 20, 2018 at 7:32 PM, Stuart Romanek notifications@github.com wrote:

Sass by default will be part of apostrophe 3's new asset pipeline, project issue here #1574 https://github.com/apostrophecms/apostrophe/issues/1574

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/apostrophecms/apostrophe/issues/1606#issuecomment-414497375, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB9fRkkxZjw8UCgAd32h8vGiR3gO7biks5uS0b2gaJpZM4WEynT .

--

THOMAS BOUTELL, CHIEF SOFTWARE ARCHITECT P'UNK AVENUE | (215) 755-1330 | punkave.com

fredrikekelund commented 6 years ago

Totally in favor of this, currently using my own SASS pipeline with Apostrophe (which also includes one or two PostCSS plugins, though).

Since this was news to me, I want to mention that the official SASS implementation has moved from Ruby to Dart, meaning that there is now a pure JS option to node-sass, namely sass. To me that was the main leg up that LESS had on SASS previously

boutell commented 6 years ago

Dart??? Somebody is using Dart??? (: (Can't be a negative of course since it compiles to JS)

On Sun, Aug 26, 2018 at 6:27 AM, Fredrik Ekelund notifications@github.com wrote:

Totally in favor of this, currently using my own SASS pipeline with Apostrophe (which also includes one or two PostCSS plugins, though).

Since this was news to me, I want to mention that the official SASS implementation has moved from Ruby to Dart, meaning that there is now a pure JS option to node-sass https://www.npmjs.com/package/node-sass, namely sass https://www.npmjs.com/package/sass. To me that was the main leg up that LESS had on SASS previously

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/apostrophecms/apostrophe/issues/1606#issuecomment-416028468, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB9fe8i4L28kqXNmTLVh4Gl7jtBSCw1ks5uUngbgaJpZM4WEynT .

--

THOMAS BOUTELL, CHIEF SOFTWARE ARCHITECT P'UNK AVENUE | (215) 755-1330 | punkave.com