search

apostrophecms / apostrophe

A full-featured, open-source content management framework built with Node.js that empowers organizations by combining in-context editing and headless architecture in a full-stack JS environment.
https://apostrophecms.com
Other
4.36k stars 590 forks source link

A3: Admin UI is not overridden when placed inside modules folder #3672

Closed stepanjakl closed 2 years ago

stepanjakl commented 2 years ago

Hello, my assumption was that anything placed inside the modules folder would overwrite the core files. I am trying to make some changes to the Admin UI by having a modified file here: modules/@apostrophecms/ui/ui/apos/components/AposContextMenu.vue. However, the changes are not appearing on the site. Any ideas?

I am using the latest Apostrophe version 3.14.2.

boutell commented 2 years ago

Are you running with APOS_DEV=1 in your environment so that Apostrophe knows to rebuild the admin UI on all restarts in development?

stepanjakl commented 2 years ago

No, but even with the flag, it doesn't change. I just tested it.

boutell commented 2 years ago

Interesting. Do you have a simple test project I can "git clone" to see this? We just did what you are describing on a client project and it worked as expected.

The latest Apostrophe version is now 3.15.0 btw, although that is not the cause of your issue.

On Thu, Mar 3, 2022 at 4:02 PM stepanjakl @.***> wrote:

No, but even with the flag, it doesn't change. I just tested it.

— Reply to this email directly, view it on GitHub https://github.com/apostrophecms/apostrophe/issues/3672#issuecomment-1058492779, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAH27JNACP6KTBNCUJ27S3U6ESHBANCNFSM5P3QIVYA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

--

THOMAS BOUTELL | CHIEF TECHNOLOGY OFFICER APOSTROPHECMS | apostrophecms.com | he/him/his

stepanjakl commented 2 years ago

I just updated to 3.15.0 and it's working. Including #3671. No kidding!

stepanjakl commented 2 years ago

I might have had the flag set for the wrong script, ups! Anyway, shouldn't running the app again (no nodemon) rebuild the admin UI nonetheless?

boutell commented 2 years ago

Supporting nodemon is why we have the flag to rebuild at restart in dev, but rebuilding the admin UI takes a long time and only a small fraction of developers need it, and those developers rarely need it all the time. So there is an environment variable to add that additional work to the rebuild of ui/src (public facing CSS and JS) that always happens.