search

apostrophecms / apostrophe

A full-featured, open-source content management framework built with Node.js that empowers organizations by combining in-context editing and headless architecture in a full-stack JS environment.
https://apostrophecms.com
Other
4.36k stars 590 forks source link

Update the new Twitter Logo #4320

Closed niranjan-kurhade closed 1 year ago

niranjan-kurhade commented 1 year ago

The problem to solve

Update the logo of Twitter to the latest logo (X).

In the footer we are still using the old logo of Twitter in the footer of the website. image

Proposed solution

New logo to be implemented.

niranjan-kurhade commented 1 year ago

Please assign this issue to me! I would like to work on it.

BoDonkey commented 1 year ago

Hi @niranjan-kurhade, are you talking about the Twitter logo in the core of Apostrophe, or on the marketing site (https://apostrophecms.com/)?

niranjan-kurhade commented 1 year ago

Hi @niranjan-kurhade, are you talking about the Twitter logo in the core of Apostrophe, or on the marketing site (https://apostrophecms.com/)?

Yes, the mentioned screenshot is of the Marketing Site.

BoDonkey commented 1 year ago

That site is internally developed on a private repo. Thanks for the heads-up and the request to help, but it isn't a repo we assign people outside of the organization to work on.

niranjan-kurhade commented 1 year ago

That site is internally developed on a private repo. Thanks for the heads-up and the request to help, but it isn't a repo we assign people outside of the organization to work on.

Okay, Np! Is there any Twitter logo in the core of Apostrophe?

BoDonkey commented 1 year ago

The core of Apostrophe uses an older version of the vue-material-design-icons package. So it actually contains the older version of the icon. Right now if users want a different set of icons they need to register them. Maybe @boutell could comment on whether it would be worth registering a new icon to be used for twitter in core.

boutell commented 1 year ago

This would only be an issue in the admin UI and we don't use it in the admin UI to my knowledge. So I think this issue can be closed. Thank you for pointing out the issue!