search

apostrophecms / apostrophe

A full-featured, open-source content management framework built with Node.js that empowers organizations by combining in-context editing and headless architecture in a full-stack JS environment.
https://apostrophecms.com
MIT License
4.35k stars 592 forks source link

Scss Mixed Declarations Warnings #4647

Open LeviticusMaximus opened 3 months ago

LeviticusMaximus commented 3 months ago

Loads of scss deprecation warnings in the console - making it pretty busy and harder to spot any other unrelated errors

Deprecation Warning: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

    ╷
92  │ ┌   .apos-theme--primary-blue {
93  │ │     @include apos-primary-mixin(#0062ff);
94  │ │   }
    │ └─── nested rule
... │
96  │     --a-base-1: #d1d3d5;
    │     ^^^^^^^^^^^^^^^^^^^ declaration
    ╵
    apos-build/default/apos/modules/@apostrophecms/ui/scss/global/_theme.scss 96:3      @import
    apos-build/default/apos/modules/@apostrophecms/ui/scss/global/import-all.scss 11:9  root stylesheet

So I'm wondering if there's a fix to mute these warnings and/or if the Apostrophe team are planning to opt-in with the new behaviour and then release updated global scss files?

Thanks

BoDonkey commented 3 months ago

Our next release will have a fix for this. In the meantime, I think the warnings won't display if you don't rebuild the admin UI, so only with APOS_DEV=1