Array modal's fields now keyboard accessible - Githubissues

apostrophecms / apostrophe

A full-featured, open-source content management framework built with Node.js that empowers organizations by combining in-context editing and headless architecture in a full-stack JS environment.

https://apostrophecms.com

Other

4.36k stars 590 forks source link

Array modal's fields now keyboard accessible #4693

Open stuartromanek opened 3 months ago

stuartromanek commented 3 months ago

Summary

Ensures array modals' existing fields are keyboard accessible when modal is opened.
Ensures new array items' fields are keyboard accessible when added

What are the specific steps to test this change?

Check these two scenarios https://github.com/user-attachments/assets/b1e1f42d-982c-4b13-ba12-4552dae470b3

What kind of change does this PR introduce?

(Check at least one)

[x] Bug fix
[ ] New feature
[ ] Refactor
[ ] Documentation
[ ] Build-related changes
[ ] Other

Make sure the PR fulfills these requirements:

[ ] It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
[ ] The changelog is updated
[ ] Related documentation has been updated
[ ] Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

stuartromanek commented 3 months ago

wouldn't it be a better solution to use a computed everywhere or a function ?

That sounds right to me.

I'm already doing too much in some of these PRs .. how would you want to move on a computed? Should i back out my fix and make a ticket for a better a solution? Or leave this and make the ticket anyway, knowing that this could change?