Focus prioritized UI in on modal open - Githubissues

apostrophecms / apostrophe

A full-featured, open-source content management framework built with Node.js that empowers organizations by combining in-context editing and headless architecture in a full-stack JS environment.

https://apostrophecms.com

Other

4.36k stars 590 forks source link

Focus prioritized UI in on modal open #4707

Closed stuartromanek closed 1 month ago

stuartromanek commented 2 months ago

Summary

https://linear.app/apostrophecms/issue/PRO-4505/%5Baccessibility%5D-focus-primary-button-in-priority

modal's trapFocus now looks for elements marked data-apos-focus-priority and prioritizes it during initial focus setting
Accessibility improvements for media uploader ui

Related

Doc template library module: https://github.com/apostrophecms/doc-template-library/pull/67
Cypress tests: https://github.com/apostrophecms/testbed/pull/300

What are the specific steps to test this change?

https://github.com/user-attachments/assets/a1eb3e36-5526-4923-ac18-376d846bb921

What kind of change does this PR introduce?

(Check at least one)

[ ] Bug fix
[x] New feature
[ ] Refactor
[ ] Documentation
[ ] Build-related changes
[ ] Other

linear[bot] commented 2 months ago

PRO-4505 [accessibility] Focus primary button in priority

stuartromanek commented 1 month ago

@ETLaurent This PR has been on a journey. Can you take a last look?