search

apostrophecms / apostrophe

A full-featured, open-source content management framework built with Node.js that empowers organizations by combining in-context editing and headless architecture in a full-stack JS environment.
https://apostrophecms.com
Other
4.36k stars 590 forks source link

fix stylelint #4730

Closed ETLaurent closed 1 month ago

ETLaurent commented 2 months ago

Summary

Before: 

➜  starter-kit-essentials git:(main) ✗ run build

> starter-kit-essentials@1.0.0 build
> NODE_ENV=production node app @apostrophecms/asset:build

🧑‍💻 Building the Public-facing modern JavaScript and Sass...
👍 Public-facing modern JavaScript and Sass is complete!
🧑‍💻 Building the Apostrophe admin UI...
WARNING in ../../../../../../../starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/ui/ui/apos/components/AposLocalePicker.vue?vue&type=style&index=0&id=b2911408&lang=scss&scoped=true (../../../../../../node_modules/css-loader/dist/cjs.js??clonedRuleSet-2.use[1]!../../../../../../node_modules/vue-loader/dist/stylePostLoader.js!../../../../../../node_modules/postcss-loader/dist/cjs.js??clonedRuleSet-2.use[2]!../../../../../../node_modules/sass-loader/dist/cjs.js??clonedRuleSet-2.use[3]!../../../../../../node_modules/vue-loader/dist/index.js??ruleSet[0]!../../../../../../../starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/ui/ui/apos/components/AposLocalePicker.vue?vue&type=style&index=0&id=b2911408&lang=scss&scoped=true)
Module Warning (from ../../../../../../node_modules/sass-loader/dist/cjs.js):
Deprecation Warning on line 8, column 2 of file:///Users/etienne/Sites/apostrophecms/starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/ui/ui/apos/components/AposLocalePicker.vue:8:2:
Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

8 |   display: block;

node_modules/apostrophe/modules/@apostrophecms/ui/ui/apos/components/AposLocalePicker.vue 9:3  root stylesheet

WARNING in ../../../../../../../starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/ui/ui/apos/components/AposLocalePicker.vue?vue&type=style&index=0&id=b2911408&lang=scss&scoped=true (../../../../../../node_modules/css-loader/dist/cjs.js??clonedRuleSet-2.use[1]!../../../../../../node_modules/vue-loader/dist/stylePostLoader.js!../../../../../../node_modules/postcss-loader/dist/cjs.js??clonedRuleSet-2.use[2]!../../../../../../node_modules/sass-loader/dist/cjs.js??clonedRuleSet-2.use[3]!../../../../../../node_modules/vue-loader/dist/index.js??ruleSet[0]!../../../../../../../starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/ui/ui/apos/components/AposLocalePicker.vue?vue&type=style&index=0&id=b2911408&lang=scss&scoped=true)
Module Warning (from ../../../../../../node_modules/sass-loader/dist/cjs.js):
Deprecation Warning on line 9, column 2 of file:///Users/etienne/Sites/apostrophecms/starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/ui/ui/apos/components/AposLocalePicker.vue:9:2:
Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

9 |   box-sizing: border-box;

node_modules/apostrophe/modules/@apostrophecms/ui/ui/apos/components/AposLocalePicker.vue 10:3  root stylesheet

WARNING in ../../../../../../../starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/ui/ui/apos/components/AposLocalePicker.vue?vue&type=style&index=0&id=b2911408&lang=scss&scoped=true (../../../../../../node_modules/css-loader/dist/cjs.js??clonedRuleSet-2.use[1]!../../../../../../node_modules/vue-loader/dist/stylePostLoader.js!../../../../../../node_modules/postcss-loader/dist/cjs.js??clonedRuleSet-2.use[2]!../../../../../../node_modules/sass-loader/dist/cjs.js??clonedRuleSet-2.use[3]!../../../../../../node_modules/vue-loader/dist/index.js??ruleSet[0]!../../../../../../../starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/ui/ui/apos/components/AposLocalePicker.vue?vue&type=style&index=0&id=b2911408&lang=scss&scoped=true)
Module Warning (from ../../../../../../node_modules/sass-loader/dist/cjs.js):
Deprecation Warning on line 10, column 2 of file:///Users/etienne/Sites/apostrophecms/starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/ui/ui/apos/components/AposLocalePicker.vue:10:2:
Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

10 |   width: 100%;

node_modules/apostrophe/modules/@apostrophecms/ui/ui/apos/components/AposLocalePicker.vue 11:3  root stylesheet

WARNING in ../../../../../../../starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/ui/ui/apos/components/AposLocalePicker.vue?vue&type=style&index=0&id=b2911408&lang=scss&scoped=true (../../../../../../node_modules/css-loader/dist/cjs.js??clonedRuleSet-2.use[1]!../../../../../../node_modules/vue-loader/dist/stylePostLoader.js!../../../../../../node_modules/postcss-loader/dist/cjs.js??clonedRuleSet-2.use[2]!../../../../../../node_modules/sass-loader/dist/cjs.js??clonedRuleSet-2.use[3]!../../../../../../node_modules/vue-loader/dist/index.js??ruleSet[0]!../../../../../../../starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/ui/ui/apos/components/AposLocalePicker.vue?vue&type=style&index=0&id=b2911408&lang=scss&scoped=true)
Module Warning (from ../../../../../../node_modules/sass-loader/dist/cjs.js):
Deprecation Warning on line 11, column 2 of file:///Users/etienne/Sites/apostrophecms/starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/ui/ui/apos/components/AposLocalePicker.vue:11:2:
Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

11 |   padding: 12px 35px;

node_modules/apostrophe/modules/@apostrophecms/ui/ui/apos/components/AposLocalePicker.vue 12:3  root stylesheet

WARNING in ../../../../../../../starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/schema/ui/apos/scss/AposInputArray.scss?vue&type=style&index=0&id=f4509a5a&lang=scss&scoped=true&external (../../../../../../node_modules/css-loader/dist/cjs.js??clonedRuleSet-2.use[1]!../../../../../../node_modules/vue-loader/dist/stylePostLoader.js!../../../../../../node_modules/postcss-loader/dist/cjs.js??clonedRuleSet-2.use[2]!../../../../../../node_modules/sass-loader/dist/cjs.js??clonedRuleSet-2.use[3]!../../../../../../../starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/schema/ui/apos/scss/AposInputArray.scss?vue&type=style&index=0&id=f4509a5a&lang=scss&scoped=true&external)
Module Warning (from ../../../../../../node_modules/sass-loader/dist/cjs.js):
Deprecation Warning on line 194, column 2 of file:///Users/etienne/Sites/apostrophecms/starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/schema/ui/apos/scss/AposInputArray.scss:194:2:
Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

194 |   height: 40px;

node_modules/apostrophe/modules/@apostrophecms/schema/ui/apos/scss/AposInputArray.scss 195:3  root stylesheet

WARNING in ../../../../../../../starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/schema/ui/apos/scss/AposInputArray.scss?vue&type=style&index=0&id=f4509a5a&lang=scss&scoped=true&external (../../../../../../node_modules/css-loader/dist/cjs.js??clonedRuleSet-2.use[1]!../../../../../../node_modules/vue-loader/dist/stylePostLoader.js!../../../../../../node_modules/postcss-loader/dist/cjs.js??clonedRuleSet-2.use[2]!../../../../../../node_modules/sass-loader/dist/cjs.js??clonedRuleSet-2.use[3]!../../../../../../../starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/schema/ui/apos/scss/AposInputArray.scss?vue&type=style&index=0&id=f4509a5a&lang=scss&scoped=true&external)
Module Warning (from ../../../../../../node_modules/sass-loader/dist/cjs.js):
Deprecation Warning on line 195, column 2 of file:///Users/etienne/Sites/apostrophecms/starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/schema/ui/apos/scss/AposInputArray.scss:195:2:
Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

195 |   padding-right: $spacing-base;

node_modules/apostrophe/modules/@apostrophecms/schema/ui/apos/scss/AposInputArray.scss 196:3  root stylesheet

WARNING in ../../../../../../../starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/schema/ui/apos/scss/AposInputArray.scss?vue&type=style&index=0&id=f4509a5a&lang=scss&scoped=true&external (../../../../../../node_modules/css-loader/dist/cjs.js??clonedRuleSet-2.use[1]!../../../../../../node_modules/vue-loader/dist/stylePostLoader.js!../../../../../../node_modules/postcss-loader/dist/cjs.js??clonedRuleSet-2.use[2]!../../../../../../node_modules/sass-loader/dist/cjs.js??clonedRuleSet-2.use[3]!../../../../../../../starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/schema/ui/apos/scss/AposInputArray.scss?vue&type=style&index=0&id=f4509a5a&lang=scss&scoped=true&external)
Module Warning (from ../../../../../../node_modules/sass-loader/dist/cjs.js):
Deprecation Warning on line 196, column 2 of file:///Users/etienne/Sites/apostrophecms/starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/schema/ui/apos/scss/AposInputArray.scss:196:2:
Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

196 |   padding-left: $spacing-base;

node_modules/apostrophe/modules/@apostrophecms/schema/ui/apos/scss/AposInputArray.scss 197:3  root stylesheet

WARNING in ../../../../../../../starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/schema/ui/apos/scss/AposInputArray.scss?vue&type=style&index=0&id=f4509a5a&lang=scss&scoped=true&external (../../../../../../node_modules/css-loader/dist/cjs.js??clonedRuleSet-2.use[1]!../../../../../../node_modules/vue-loader/dist/stylePostLoader.js!../../../../../../node_modules/postcss-loader/dist/cjs.js??clonedRuleSet-2.use[2]!../../../../../../node_modules/sass-loader/dist/cjs.js??clonedRuleSet-2.use[3]!../../../../../../../starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/schema/ui/apos/scss/AposInputArray.scss?vue&type=style&index=0&id=f4509a5a&lang=scss&scoped=true&external)
Module Warning (from ../../../../../../node_modules/sass-loader/dist/cjs.js):
Deprecation Warning on line 197, column 2 of file:///Users/etienne/Sites/apostrophecms/starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/schema/ui/apos/scss/AposInputArray.scss:197:2:
Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

197 |   text-align: left;

node_modules/apostrophe/modules/@apostrophecms/schema/ui/apos/scss/AposInputArray.scss 198:3  root stylesheet

WARNING in ../../../../../../../starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/schema/ui/apos/scss/AposInputArray.scss?vue&type=style&index=0&id=f4509a5a&lang=scss&scoped=true&external (../../../../../../node_modules/css-loader/dist/cjs.js??clonedRuleSet-2.use[1]!../../../../../../node_modules/vue-loader/dist/stylePostLoader.js!../../../../../../node_modules/postcss-loader/dist/cjs.js??clonedRuleSet-2.use[2]!../../../../../../node_modules/sass-loader/dist/cjs.js??clonedRuleSet-2.use[3]!../../../../../../../starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/schema/ui/apos/scss/AposInputArray.scss?vue&type=style&index=0&id=f4509a5a&lang=scss&scoped=true&external)
Module Warning (from ../../../../../../node_modules/sass-loader/dist/cjs.js):
Deprecation Warning on line 198, column 2 of file:///Users/etienne/Sites/apostrophecms/starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/schema/ui/apos/scss/AposInputArray.scss:198:2:
Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

198 |   background-color: var(--a-base-9);

node_modules/apostrophe/modules/@apostrophecms/schema/ui/apos/scss/AposInputArray.scss 199:3  root stylesheet

WARNING in ../../../../../../../starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/schema/ui/apos/scss/AposInputArray.scss?vue&type=style&index=0&id=f4509a5a&lang=scss&scoped=true&external (../../../../../../node_modules/css-loader/dist/cjs.js??clonedRuleSet-2.use[1]!../../../../../../node_modules/vue-loader/dist/stylePostLoader.js!../../../../../../node_modules/postcss-loader/dist/cjs.js??clonedRuleSet-2.use[2]!../../../../../../node_modules/sass-loader/dist/cjs.js??clonedRuleSet-2.use[3]!../../../../../../../starter-kit-essentials/node_modules/apostrophe/modules/@apostrophecms/schema/ui/apos/scss/AposInputArray.scss?vue&type=style&index=0&id=f4509a5a&lang=scss&scoped=true&external)
Module Warning (from ../../../../../../node_modules/sass-loader/dist/cjs.js):
12 repetitive deprecation warnings omitted.
Run in verbose mode to see all warnings.

webpack compiled with 10 warnings
👍 Apostrophe admin UI is complete!
🧑‍💻 Building the Raw CSS and JS...
👍 Raw CSS and JS is complete!

After:

➜  starter-kit-essentials git:(main) ✗ run build

> starter-kit-essentials@1.0.0 build
> NODE_ENV=production node app @apostrophecms/asset:build

🧑‍💻 Building the Public-facing modern JavaScript and Sass...
👍 Public-facing modern JavaScript and Sass is complete!
🧑‍💻 Building the Apostrophe admin UI...
👍 Apostrophe admin UI is complete!
🧑‍💻 Building the Raw CSS and JS...
👍 Raw CSS and JS is complete!

What are the specific steps to test this change?

For example:

  1. Run the website and log in as an admin
  2. Open a piece manager modal and select several pieces
  3. Click the "Archive" button on the top left of the manager and confirm that it should proceed
  4. Check that all pieces have been archived properly

What kind of change does this PR introduce?

(Check at least one)

Make sure the PR fulfills these requirements:

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

linear[bot] commented 2 months ago

PRO-6571 Figure out why we're getting mixed declaration errors with Pro modules when we actually build Apostrophe projects, but not from the linter when we PR changes in those modules.

ETLaurent commented 2 months ago

Don't think we need to edit the changelog, this is pure code style