apostrophecms / docs

ApostropheCMS documentation.
MIT License
4 stars 14 forks source link

Pro 5803 s3 privacy #380

Closed BoDonkey closed 4 months ago

BoDonkey commented 4 months ago

Summary

Summarize the changes briefly, including which issue/ticket this resolves. If it closes an existing Github issue, include "Closes #[issue number]" This PR partially closes PRO-5803. It changes both the guide page on using S3 and the uploadfs reference to include a description of the bucketObjectsACL option.

What are the specific steps to test this change?

For example:

  1. Run the website and log in as an admin
  2. Open a piece manager modal and select several pieces
  3. Click the "Archive" button on the top left of the manager and confirm that it should proceed
  4. Check that all pieces have been archived properly
  5. Bring the documentation up.
  6. Navigate to http://localhost:5173/reference/modules/uploadfs.html#s3-storage-options and http://localhost:5173/cookbook/using-s3-storage.html

    What kind of change does this PR introduce?

    (Check at least one)

Make sure the PR fulfills these requirements:

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

linear[bot] commented 4 months ago

PRO-5803 Document: As a developer I don't have to make my S3 bucket public