apostrophecms / oembetter

A modern oembed client. Allows you to register filters to improve or supply oembed support for sites that don't normally have it. You can also supply a whitelist of services you trust to prevent XSS attacks.
50 stars 9 forks source link

The request package has been deprecated a loooooooooooong time #17

Closed robogeek closed 9 months ago

robogeek commented 3 years ago

The problem to solve

When installing my application, I get this message:

npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142

My application (AkashaCMS) does not directly depend on request, but instead oembetter (this package) does.

Proposed solution

There are other packages that perform similar functions, such as fetch, which are not deprecated.

Rewrite oembetter so it does not depend on request.

boutell commented 3 years ago

This would make a great PR if you're interested.

On Mon, Oct 4, 2021 at 8:14 PM David Herron @.***> wrote:

The problem to solve

When installing my application, I get this message:

npm WARN deprecated @.***: request has been deprecated, see request/request#3142 https://github.com/request/request/issues/3142

My application (AkashaCMS) does not directly depend on request, but instead oembetter (this package) does. Proposed solution

There are other packages that perform similar functions, such as fetch, which are not deprecated.

Rewrite oembetter so it does not depend on request.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/apostrophecms/oembetter/issues/17, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAH27MJGQGIN7KAZDC623TUFI7PNANCNFSM5FKQ4KBA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--

THOMAS BOUTELL | CHIEF TECHNOLOGY OFFICER APOSTROPHECMS | apostrophecms.com | he/him/his

millette commented 9 months ago

Fixed with 1.0.2 - 2022-12-21.

boutell commented 9 months ago

Good catch. Cleaning up.