search

apostrophecms / random-words

Generate one or more common English words. Intended for use as sample text, for example generating random blog posts for testing
MIT License
249 stars 72 forks source link

IE10 error "Expected: ';'" #5

Closed reginaldwhite closed 6 years ago

reginaldwhite commented 6 years ago

We support IE10 because we have to. IE11 is fine; however, IE10 throws SCRIPT1004: Expected ';' on line 260 which is the ES6 let keyword. I see other places in the code that use var. Could we just use that? I was using 0.0.1 heretofore with no problem; however, it does not support maxLength.

capturerw

boutell commented 6 years ago

I recommend using babel if you must support EOL'd browsers. I'm open to a babel compilation script and a dist/ folder etc. being added via a PR though.

On Wed, Mar 14, 2018 at 1:58 PM, Matt Foley notifications@github.com wrote:

We support IE10 because we have to. IE11 is fine; however, IE10 throws SCRIPT1004: Expected ';' on line 260 which is the ES6 let keyword. I see other places in the code that use var. Could we just use that? I was using 0.0.1 heretofore with no problem; however, it does not support maxLength.

[image: capturerw] https://user-images.githubusercontent.com/5862326/37421473-6729cd7c-2787-11e8-8f8e-a194bbaca2ab.PNG

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/punkave/random-words/issues/5, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB9fZRGCpVTg8lmmBO5Vlj1EUnvcHHMks5teVpRgaJpZM4Sq6Ir .

--

THOMAS BOUTELL, CHIEF SOFTWARE ARCHITECT P'UNK AVENUE | (215) 755-1330 | punkave.com

reginaldwhite commented 6 years ago

We are using babel, but not on _nodemodules. Thanks, I'll add your directory for a short term solution. I would love to submit a compilation script PR when I have the bandwidth. Thanks for the useful package.

boutell commented 6 years ago

You're welcome... you might check out sanitize-html for how we did it on that one.

On Thu, Mar 15, 2018 at 1:46 PM, Matt Foley notifications@github.com wrote:

We are using babel, but not on node_modules. Thanks, I'll add your directory for a short term solution. I would love to submit a complication script PR when I have the bandwidth. Thanks for the useful package.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/punkave/random-words/issues/5#issuecomment-373464614, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB9fRkJEJ3TtedMgSj6y7XgDBQMXN1uks5teqj0gaJpZM4Sq6Ir .

--

THOMAS BOUTELL, CHIEF SOFTWARE ARCHITECT P'UNK AVENUE | (215) 755-1330 | punkave.com