apostrophecms / sanitize-html

Clean up user-submitted HTML, preserving whitelisted elements and whitelisted attributes on a per-element basis. Built on htmlparser2 for speed and tolerance
MIT License
3.68k stars 349 forks source link

Update README.md - comment out circleci #628

Closed alfreema closed 1 year ago

alfreema commented 1 year ago

Comment out the circleci reference in the README.md. It's misleading to the community that something is untrustworthy or broken.

Summary

Summarize the changes briefly, including which issue/ticket this resolves. If it closes an existing Github issue, include "Closes #[issue number]"

What are the specific steps to test this change?

For example:

  1. Run the website and log in as an admin
  2. Open a piece manager modal and select several pieces
  3. Click the "Archive" button on the top left of the manager and confirm that it should proceed
  4. Check that all pieces have been archived properly

What kind of change does this PR introduce?

(Check at least one)

Make sure the PR fulfills these requirements:

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

alfreema commented 1 year ago

Okidoke I removed the reference entirely from README.md (instead of commenting it out), and then removed the .circleci directory. I believe that last commit is reflected in this Pull Request now, but I have never modified a Pull Request after submitting it so let me know if I screwed it up. :)