apostrophecms / stagecoach

Painlessly deploy node.js applications to your staging and production servers. Use a standard VPS or dedicated server to host both Node and traditional Apache-based websites. Pairs nicely with nginx and mechanic.
306 stars 29 forks source link

You can now prepend something to all ssh commands by setting SSH_OPTIONS #28

Closed boutell closed 5 years ago

boutell commented 5 years ago

I need this to pass the -i option so I can specify a specific private key file.

boutell commented 5 years ago

Should be good catch

On Thu, Aug 1, 2019 at 1:49 PM Alex Bea notifications@github.com wrote:

@abea commented on this pull request.

In bin/sc-shell https://github.com/apostrophecms/stagecoach/pull/28#discussion_r309820701 :

@@ -51,6 +51,6 @@ if [ -z "$2" ] ; then

ssh -t -p $SSH_PORT $MY_USER@$SERVER $ALLOW_FOR_SUDO "cd $DIR/current && whoami && bash -i"

Should it not be applied here as well?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/apostrophecms/stagecoach/pull/28?email_source=notifications&email_token=AAAH27NEQCPTDCPA7G7TJHLQCMO4JA5CNFSM4IIS4HB2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCAKIF5Q#pullrequestreview-269779702, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAH27MHH4NCHSOI5CRZ2Q3QCMO4JANCNFSM4IIS4HBQ .

--

Thomas Boutell, Chief Software Architect Pronouns: he / him / his P'unk Avenue | (215) 755-1330 | punkave.com

boutell commented 5 years ago

GOLDANG IT you're right please look one more time

On Mon, Aug 5, 2019 at 3:09 PM Alex Bea notifications@github.com wrote:

@abea commented on this pull request.

In bin/sc-shell https://github.com/apostrophecms/stagecoach/pull/28#discussion_r310750029 :

@@ -47,10 +47,10 @@ fi echo $ALLOW_FOR_SUDO

if [ -z "$2" ] ; then

  • echo ssh -t -p $SSH_PORT $MY_USER@$SERVER $ALLOW_FOR_SUDO "cd $DIR/current && whoami && bash -i"
  • echo ssh -t $SSH_OPTIONS -p $SSH_PORT $MY_USER@$SERVER $ALLOW_FOR_SUDO "cd $DIR/current && whoami && bash -i"

    ssh -t -p $SSH_PORT $MY_USER@$SERVER $ALLOW_FOR_SUDO "cd $DIR/current && whoami && bash -i"

It's still not on line 52. ssh -t -p $SSH_PORT $MY_USER@$SERVER $ALLOW_FOR_SUDO "cd $DIR/current && whoami && bash -i". Is that intentional?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/apostrophecms/stagecoach/pull/28?email_source=notifications&email_token=AAAH27JCRCVY7RDOQAK2SGLQDB3F3A5CNFSM4IIS4HB2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCATGQIY#pullrequestreview-270952483, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAH27JBICQU2KPHIVZDQCTQDB3F3ANCNFSM4IIS4HBQ .

--

Thomas Boutell, Chief Software Architect Pronouns: he / him / his P'unk Avenue | (215) 755-1330 | punkave.com