search

apotapov / gdx-artemis

Fork of artemis entity-system (http://gamadu.com/artemis/) refactored to integrate with Libgdx (http://libgdx.badlogicgames.com/)
Other
53 stars 5 forks source link

GWT Support #36

Closed chanceVermilion closed 10 years ago

chanceVermilion commented 10 years ago

I saw here: https://github.com/junkdog/artemis-odb/issues/56 that you mentioned looking into GWT support. Did you come to any conclusion regarding the feasibility? I spent some time trying to make everything compatible, but BitSet and UUID have a long chain of dependencies on non-GWT types.

apotapov commented 10 years ago

I currently have a bug file to potentially replace the java.util.BitSet with OpenBitSet from Lucene: https://github.com/apotapov/gdx-artemis/issues/20

I've used it successfully in another project and got some nice performance results. I'll take a look at moving it into gdx-artemis.

Not sure what to do about UUID. Any insight is appreciated.

xaguzman commented 10 years ago

how about using libgdx's own bitset implementation?

http://libgdx.badlogicgames.com/nightlies/docs/api/com/badlogic/gdx/utils/Bits.html

haven't really digged into it, so not sure GWT would support it

apotapov commented 10 years ago

I'll be honest, this project is on the back burner for me right now. I currently have a few other high priority things on my plate.

The change you are proposing touches a lot of the core functionality and will require a lot of testing. If you submit a pull request with some unit tests I can look at merging it in. Otherwise, perhaps forking the repo and making the changes you need yourself would be a better solution. Apologies.

apotapov commented 10 years ago

Looks like both BitSet and UUID dependency has been eliminated. Take a look at #40. Hopefully this will resolve the issue with GWT. Feel free to reopen if there is still more work to be done.